From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sat, 14 Jan 2012 21:16:58 -0500 Subject: [U-Boot] [PATCH 12/17] lcd: Add support for flushing LCD fb from dcache after update In-Reply-To: References: <1326588449-1794-1-git-send-email-sjg@chromium.org> <201201142042.06025.vapier@gentoo.org> Message-ID: <201201142116.59100.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 14 January 2012 20:57:25 Simon Glass wrote: > On Sat, Jan 14, 2012 at 5:42 PM, Mike Frysinger wrote: > > On Saturday 14 January 2012 19:47:24 Simon Glass wrote: > >> --- a/common/cmd_echo.c > >> +++ b/common/cmd_echo.c > >> @@ -44,8 +44,9 @@ int do_echo(cmd_tbl_t *cmdtp, int flag, int argc, char > >> * const argv[]) } > >> } > >> > >> + /* Use puts() so that the LCD sees it as a new line */ > >> if (putnl) > >> - putc('\n'); > >> + puts("\n"); > >> > >> return 0; > >> } > > > > this sounds like a hack for a broken LCD core and so the fix should be > > somewhere in there > > Well it's actually that I don't want to flush after every character > (it slows things down a lot) right, but ... > so puts is a good place to look most puts() that i've seen are simple loops that call putc() > I suppose we could flush after every newline we see in lcd_putc(). that would be the right way to go i think -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: