From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sun, 15 Jan 2012 12:35:01 -0500 Subject: [U-Boot] [PATCH 1/3] common: add possibility for readline_into_buffer timeout In-Reply-To: <1326614022-24014-2-git-send-email-hs@denx.de> References: <1326614022-24014-1-git-send-email-hs@denx.de> <1326614022-24014-2-git-send-email-hs@denx.de> Message-ID: <201201151235.01689.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sunday 15 January 2012 02:53:40 Heiko Schocher wrote: > --- a/common/main.c > +++ b/common/main.c > > + if ((first) && (timeout)) { those inner parens make no sense > + ulong start = get_timer(0); > + ulong delay = timeout * CONFIG_SYS_HZ; what do you want the timeout to be in ? milliseconds ? then make that part of the API (add comments to the relevant funcs), and drop the CONFIG_SYS_HZ usage. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: