Hi, On Thu, Feb 02, 2012 at 11:00:27PM +0530, Tarun Kanti DebBarma wrote: > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index 0b05629..6ea7390 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -28,7 +28,10 @@ > #include > #include > > +static LIST_HEAD(omap_gpio_list); I guess it's now too late because patch is acked and everything, but I think if you make the driver handle one bank alone and just instantiate it multiple times (omap_gpio.0, omap_gpio.1, omap_gpio.3, etc) driver would be faaaaaar simpler. -- balbi