All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: David Miller <davem@davemloft.net>
Cc: simon.wunderlich@s2003.tu-chemnitz.de, netdev@vger.kernel.org,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Patrick McHardy <kaber@trash.net>,
	Jamal Hadi Salim <hadi@cyberus.ca>,
	Johannes Berg <johannes@sipsolutions.net>,
	"John W. Linville" <linville@tuxdriver.com>,
	Marek Lindner <lindner_marek@yahoo.de>,
	Sven Eckelmann <sven@narfation.org>,
	netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
	coreteam@netfilter.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] skbuff: Add new tc classify variable
Date: Tue, 7 Feb 2012 21:16:33 +0100	[thread overview]
Message-ID: <20120207201633.GB26533@pandem0nium> (raw)
In-Reply-To: <20120207.135841.1753473725075272902.davem@davemloft.net>

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

Hello David,

On Tue, Feb 07, 2012 at 01:58:41PM -0500, David Miller wrote:
> From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
> Date: Tue,  7 Feb 2012 19:39:08 +0100
> 
> > The linux traffic control mechanism has different ways to select the
> > correct class of a qdisc. A common way to do this is to use tc filters
> > that are directly attached to a qdisc. Another approach is to use the
> > iptables classify module. The latter one can reduce the amount of work
> > necessary to process a packet when iptables is already involved in the
> > packet classification.
> 
> Do not bloat up sk_buff any more.  Add this, and the other existing
> tc_* members to the qdisc SKB control block instead.
> 

Thanks for your feedback!

I guess you mean skb->cb, but this is also used within mac80211 for various things
(quoting include/net/mac80211.h):

 * struct ieee80211_tx_info - skb transmit information
 *
 * This structure is placed in skb->cb for three uses:
 *  (1) mac80211 TX control - mac80211 tells the driver what to do
 *  (2) driver internal use (if applicable)
 *  (3) TX status information - driver tells mac80211 what happened

We could give it a try, but we most probably run into conflicts again.

I've messed up the CCs in my initial mail (and just resent it) - sorry about that.
Maybe the mac80211 guys have a suggestion as well :)

Cheers,
	Simon

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-02-07 20:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27 16:19 [PATCH] skbuff: Add new tc classify variable Simon Wunderlich
2012-02-07 18:39 ` Simon Wunderlich
2012-02-07 18:58 ` David Miller
2012-02-07 20:16   ` Simon Wunderlich [this message]
2012-02-07 20:33     ` Dave Taht
2012-02-08  9:21     ` Eric Dumazet
2012-02-08  9:21       ` Eric Dumazet
2012-02-08 14:48       ` jamal
2012-02-08 14:48         ` jamal
2012-02-07 19:05 ` Stephen Hemminger
2012-02-07 19:57   ` Simon Wunderlich
2012-02-07 21:45     ` Stephen Hemminger
2012-02-08  8:54       ` Florian Westphal
  -- strict thread matches above, loose matches on Subject: below --
2012-01-27 16:19 Simon Wunderlich
2012-01-27 16:19 ` Simon Wunderlich
2012-01-27 16:19 Simon Wunderlich
2012-01-27 16:19 ` Simon Wunderlich
2012-01-27 16:19 Simon Wunderlich
2012-01-27 16:19 ` Simon Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120207201633.GB26533@pandem0nium \
    --to=simon.wunderlich@s2003.tu-chemnitz.de \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=johannes@sipsolutions.net \
    --cc=kaber@trash.net \
    --cc=lindner_marek@yahoo.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.