From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] arm: omap3: cm-t35: fix section mismatch warning Date: Tue, 7 Feb 2012 21:35:57 -0800 Message-ID: <20120208053556.GB1426@atomide.com> References: <20120205012556.GG1426@atomide.com> <1328441980-28892-1-git-send-email-grinberg@compulab.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:44956 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751044Ab2BHFgE (ORCPT ); Wed, 8 Feb 2012 00:36:04 -0500 Content-Disposition: inline In-Reply-To: <1328441980-28892-1-git-send-email-grinberg@compulab.co.il> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Igor Grinberg Cc: Arnd Bergmann , Russell King , Olof Johansson , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org * Igor Grinberg [120205 03:08]: > WARNING: arch/arm/mach-omap2/built-in.o(.text+0xeae8): > Section mismatch in reference from the function cm_t35_init_usbh() > to the (unknown reference) .init.data:(unknown) > The function cm_t35_init_usbh() references > the (unknown reference) __initdata (unknown). > This is often because cm_t35_init_usbh lacks a __initdata > annotation or the annotation of (unknown) is wrong. > > Signed-off-by: Igor Grinberg > --- > Sorry about this one. I fixed similar problem for cm-t3517 a while ago, > but somehow missed cm-t35. Thanks for spotting. > Probably enabling the CONFIG_DEBUG_SECTION_MISMATCH in defconfigs > can raise people awareness for this. Thanks applying into fixes. Yes let's plan on doing that, and also make sure we're actually seeing the warnings.. Tony > arch/arm/mach-omap2/board-cm-t35.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c > index d839c05..a8cedbe 100644 > --- a/arch/arm/mach-omap2/board-cm-t35.c > +++ b/arch/arm/mach-omap2/board-cm-t35.c > @@ -436,7 +436,7 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = { > .reset_gpio_port[2] = -EINVAL > }; > > -static void cm_t35_init_usbh(void) > +static void __init cm_t35_init_usbh(void) > { > int err; > > -- > 1.7.3.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 7 Feb 2012 21:35:57 -0800 Subject: [PATCH] arm: omap3: cm-t35: fix section mismatch warning In-Reply-To: <1328441980-28892-1-git-send-email-grinberg@compulab.co.il> References: <20120205012556.GG1426@atomide.com> <1328441980-28892-1-git-send-email-grinberg@compulab.co.il> Message-ID: <20120208053556.GB1426@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Igor Grinberg [120205 03:08]: > WARNING: arch/arm/mach-omap2/built-in.o(.text+0xeae8): > Section mismatch in reference from the function cm_t35_init_usbh() > to the (unknown reference) .init.data:(unknown) > The function cm_t35_init_usbh() references > the (unknown reference) __initdata (unknown). > This is often because cm_t35_init_usbh lacks a __initdata > annotation or the annotation of (unknown) is wrong. > > Signed-off-by: Igor Grinberg > --- > Sorry about this one. I fixed similar problem for cm-t3517 a while ago, > but somehow missed cm-t35. Thanks for spotting. > Probably enabling the CONFIG_DEBUG_SECTION_MISMATCH in defconfigs > can raise people awareness for this. Thanks applying into fixes. Yes let's plan on doing that, and also make sure we're actually seeing the warnings.. Tony > arch/arm/mach-omap2/board-cm-t35.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c > index d839c05..a8cedbe 100644 > --- a/arch/arm/mach-omap2/board-cm-t35.c > +++ b/arch/arm/mach-omap2/board-cm-t35.c > @@ -436,7 +436,7 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = { > .reset_gpio_port[2] = -EINVAL > }; > > -static void cm_t35_init_usbh(void) > +static void __init cm_t35_init_usbh(void) > { > int err; > > -- > 1.7.3.4 >