From: Paul Brook <paul@codesourcery.com>
To: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition
Date: Wed, 8 Feb 2012 12:27:58 +0000 [thread overview]
Message-ID: <201202081228.00120.paul@codesourcery.com> (raw)
In-Reply-To: <CAEgOgz7WOWD_UFUo0jDsrWE4q1PGH-0oEdy9KfMSjrcD1u94qg@mail.gmail.com>
> 2012/2/8 Paul Brook <paul@codesourcery.com>
>
> > > > I suspect we want to replace the arm_load_kernel call with an
> > > > arm_linux_loader device with appropriate properties.
> > >
> > > Ok, so does this mean the machine model would still explicitly
> > > instantiate the bootloader device?
> >
> > Yes. Bootloaders inherently have machine specific knowledge. They need
> > to know ram location, board ID, secondary CPU boot protocols, etc.
> > Requiring the user specify all these things separately from the rest of
> > the machine description is IMO not acceptable.
>
> So what im suggesting here is that machines export these properties to a
> globally accessible location. Perhaps via the machine opts mechanism? Then
> we are in a best of both worls situation where machine models do not need
> bootloader awareness yet bootloaders can still query qemu for ram_size,
> smp#, board_id and friends.
Hmm, I suppose this might work. I'm not sure what you think the benefit of
this is though. Fact is the machine needs to have bootloader awareness,
whether it be instantating an object or setting magic variables.
Having devices rummage around in global state feels messy. I'd much rather
use actual properties on the device. IMO changing the bootloader is similar
complexity to (say) changing a UART. i.e. it's a board-level change not an
end-user level change. Board-level changes are something that will happen
after QOM conversion, i.e. when we replace machine->init with a board config
file.
Paul
next prev parent reply other threads:[~2012-02-08 12:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 7:55 [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition Peter A. G. Crosthwaite
2012-02-08 9:06 ` Paul Brook
2012-02-08 10:11 ` Peter Crosthwaite
2012-02-08 10:44 ` Paul Brook
2012-02-08 11:10 ` Peter Crosthwaite
2012-02-08 11:39 ` Paul Brook
2012-02-08 11:59 ` Peter Crosthwaite
2012-02-08 12:27 ` Paul Brook [this message]
2012-02-08 12:41 ` Alexander Graf
2012-02-08 13:04 ` Peter Crosthwaite
2012-02-08 13:10 ` Alexander Graf
2012-02-08 13:30 ` Peter Crosthwaite
2012-02-08 13:35 ` Alexander Graf
2012-02-08 14:05 ` Peter Crosthwaite
2012-02-08 14:17 ` Alexander Graf
2012-02-08 14:20 ` Paul Brook
2012-02-08 14:39 ` Peter Crosthwaite
2012-02-08 14:56 ` Paul Brook
2012-02-08 15:14 ` Peter Crosthwaite
2012-02-08 15:57 ` Paul Brook
2012-02-08 16:03 ` Peter Crosthwaite
2012-02-08 16:15 ` Paul Brook
2012-02-08 16:35 ` Anthony Liguori
2012-02-09 1:22 ` Peter Crosthwaite
2012-02-09 12:03 ` Paul Brook
2012-02-08 16:20 ` Anthony Liguori
2012-02-08 13:47 ` Anthony Liguori
2012-02-20 19:43 ` Peter Maydell
2012-02-20 19:51 ` Andreas Färber
2012-02-20 19:56 ` Peter Maydell
2012-02-21 9:15 ` Peter Crosthwaite
2012-02-21 10:20 ` Peter Maydell
2012-02-08 13:41 ` Anthony Liguori
2012-02-09 13:22 ` Andreas Färber
2012-02-10 2:11 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202081228.00120.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.