From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvOft-0005JJ-LT for qemu-devel@nongnu.org; Thu, 09 Feb 2012 02:44:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvOfp-0006QI-GY for qemu-devel@nongnu.org; Thu, 09 Feb 2012 02:44:13 -0500 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:38765) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvOfp-0006QA-9N for qemu-devel@nongnu.org; Thu, 09 Feb 2012 02:44:09 -0500 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 9 Feb 2012 07:44:03 -0000 Date: Thu, 9 Feb 2012 08:43:39 +0100 From: Thomas Huth Message-ID: <20120209084339.79536829@BR8GGW75.de.ibm.com> In-Reply-To: <20120209002609.GH11852@truffala.fritz.box> References: <1328680437-31779-1-git-send-email-david@gibson.dropbear.id.au> <20120208104840.GG11852@truffala.fritz.box> <20120208142735.3bbc7cd6@BR8GGW75.de.ibm.com> <20120209002609.GH11852@truffala.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC64: Add support for ldbrx and stdbrx instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-ppc@nongnu.org Cc: qemu-devel@nongnu.org, David Gibson Am Thu, 9 Feb 2012 11:26:09 +1100 schrieb David Gibson : > On Wed, Feb 08, 2012 at 02:27:35PM +0100, Thomas Huth wrote: > > Am Wed, 8 Feb 2012 21:48:40 +1100 > > schrieb David Gibson : > > > > > On Wed, Feb 08, 2012 at 10:54:21AM +0400, malc wrote: > > > > On Wed, 8 Feb 2012, David Gibson wrote: > > > > > > > > > From: Thomas Huth > > > > > > > > > > These instructions for loading and storing byte-swapped 64-bit values have > > > > > been introduced in PowerISA 2.06. > > > > > > > > > > Signed-off-by: Thomas Huth > > > > > --- > > > > > target-ppc/translate.c | 30 ++++++++++++++++++++++++++++++ > > > > > 1 files changed, 30 insertions(+), 0 deletions(-) > > > > > > > > I seem to recall that POWER5 machine i had access to didn't have > > > > ld/stdbrx while CBE did have it (or was it the other way around?) > > > > so question is - is PPC_64B sufficient? > > > > > > Ah, I think it's not. I think I spotted that before, but then forgot > > > about it. Thanks for the reminder. > > > > Maybe it's a better idea to use PPC_64BX here? ... but that flag seems > > to be missing in POWERPC_INSNS_POWER7... David, could PPC_64BX also be > > included in that flag list? > > Um.. what exactly do you mean by 64BX? > There is a definition in target-ppc/cpu.h: /* New 64 bits extensions (PowerPC 2.0x) */ PPC_64BX = 0x0000000000000040ULL, According to the comment, I thought the PPC_64BX might be designed for new 64-bit instructions? Thomas