From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvT3d-0000AN-QE for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:25:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvT3c-0006Hz-3R for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:25:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvT3b-0006Hq-Sq for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:25:00 -0500 Date: Thu, 9 Feb 2012 14:24:55 +0200 From: Gleb Natapov Message-ID: <20120209122455.GI18866@redhat.com> References: <1328698819-31269-1-git-send-email-kraxel@redhat.com> <1328698819-31269-7-git-send-email-kraxel@redhat.com> <20120209085658.GE18866@redhat.com> <4F33B56F.5020000@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F33B56F.5020000@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 6/6] suspend: make rtc alarm wakeup the guest. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org On Thu, Feb 09, 2012 at 01:00:47PM +0100, Gerd Hoffmann wrote: > On 02/09/12 09:56, Gleb Natapov wrote: > > On Wed, Feb 08, 2012 at 12:00:19PM +0100, Gerd Hoffmann wrote: > >> Add a 'wakeup' property to the mc146818rtc. It is on by default. > >> When enabled the rtc will wake up the guest when the alarm fires. > >> > >> Signed-off-by: Gerd Hoffmann > >> --- > >> hw/mc146818rtc.c | 5 +++++ > >> 1 files changed, 5 insertions(+), 0 deletions(-) > >> > >> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c > >> index 314ed52..3b912c6 100644 > >> --- a/hw/mc146818rtc.c > >> +++ b/hw/mc146818rtc.c > >> @@ -86,6 +86,7 @@ typedef struct RTCState { > >> uint8_t cmos_index; > >> struct tm current_tm; > >> int32_t base_year; > >> + uint32_t wakeup; > >> qemu_irq irq; > >> qemu_irq sqw_irq; > >> int it_shift; > >> @@ -437,6 +438,9 @@ static void rtc_update_second2(void *opaque) > >> > >> s->cmos_data[RTC_REG_C] |= REG_C_AF; > >> if (s->cmos_data[RTC_REG_B] & REG_B_AIE) { > >> + if (s->wakeup) { > >> + qemu_system_wakeup_request(); > >> + } > > RTC should do wakeup only if RTC_EN bit is set pm1en. > > --verbose please. Which register, which bit? There is no RTC_EN in > hw/mc146818rtc.* ... > Entering --verbose mode. Here we are on ACPI territory, not RTC :) RTC just provides one input into ACPI wakeup machinery (Figure 4-11 in ACPI spec version 4). I am talking about ACPI_BITMASK_RT_CLOCK_ENABLE from hw/acpi.h. It is called RTC_EN in ACPI spec (man, we should rename them back!). Spec says that RTC alarm can wakeup the system only if RTC_EN is set in PM1x_EN register. This way OSPM can control which events can do wakeup. Notice that for power button wakeup BWRBTN_EN is ignored. > Is this enable bit specifically for wakeup from suspend? > No, RTC alarm can be configured to generate SCI interrupt while system is running. -- Gleb. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH v3 6/6] suspend: make rtc alarm wakeup the guest. Date: Thu, 9 Feb 2012 14:24:55 +0200 Message-ID: <20120209122455.GI18866@redhat.com> References: <1328698819-31269-1-git-send-email-kraxel@redhat.com> <1328698819-31269-7-git-send-email-kraxel@redhat.com> <20120209085658.GE18866@redhat.com> <4F33B56F.5020000@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4F33B56F.5020000@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Gerd Hoffmann Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org On Thu, Feb 09, 2012 at 01:00:47PM +0100, Gerd Hoffmann wrote: > On 02/09/12 09:56, Gleb Natapov wrote: > > On Wed, Feb 08, 2012 at 12:00:19PM +0100, Gerd Hoffmann wrote: > >> Add a 'wakeup' property to the mc146818rtc. It is on by default. > >> When enabled the rtc will wake up the guest when the alarm fires. > >> > >> Signed-off-by: Gerd Hoffmann > >> --- > >> hw/mc146818rtc.c | 5 +++++ > >> 1 files changed, 5 insertions(+), 0 deletions(-) > >> > >> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c > >> index 314ed52..3b912c6 100644 > >> --- a/hw/mc146818rtc.c > >> +++ b/hw/mc146818rtc.c > >> @@ -86,6 +86,7 @@ typedef struct RTCState { > >> uint8_t cmos_index; > >> struct tm current_tm; > >> int32_t base_year; > >> + uint32_t wakeup; > >> qemu_irq irq; > >> qemu_irq sqw_irq; > >> int it_shift; > >> @@ -437,6 +438,9 @@ static void rtc_update_second2(void *opaque) > >> > >> s->cmos_data[RTC_REG_C] |= REG_C_AF; > >> if (s->cmos_data[RTC_REG_B] & REG_B_AIE) { > >> + if (s->wakeup) { > >> + qemu_system_wakeup_request(); > >> + } > > RTC should do wakeup only if RTC_EN bit is set pm1en. > > --verbose please. Which register, which bit? There is no RTC_EN in > hw/mc146818rtc.* ... > Entering --verbose mode. Here we are on ACPI territory, not RTC :) RTC just provides one input into ACPI wakeup machinery (Figure 4-11 in ACPI spec version 4). I am talking about ACPI_BITMASK_RT_CLOCK_ENABLE from hw/acpi.h. It is called RTC_EN in ACPI spec (man, we should rename them back!). Spec says that RTC alarm can wakeup the system only if RTC_EN is set in PM1x_EN register. This way OSPM can control which events can do wakeup. Notice that for power button wakeup BWRBTN_EN is ignored. > Is this enable bit specifically for wakeup from suspend? > No, RTC alarm can be configured to generate SCI interrupt while system is running. -- Gleb.