From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvmBw-0007cL-SD for qemu-devel@nongnu.org; Fri, 10 Feb 2012 03:50:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvmBv-0008JE-NM for qemu-devel@nongnu.org; Fri, 10 Feb 2012 03:50:52 -0500 Received: from indium.canonical.com ([91.189.90.7]:41397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvmBv-0008Is-Il for qemu-devel@nongnu.org; Fri, 10 Feb 2012 03:50:51 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1RvmBt-0003MS-Pt for ; Fri, 10 Feb 2012 08:50:49 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id BBD372E823C for ; Fri, 10 Feb 2012 08:50:49 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Fri, 10 Feb 2012 08:42:55 -0000 From: Bjoern Bornemann Sender: bounces@canonical.com References: <20110811164621.32220.49907.malonedeb@chaenomeles.canonical.com> Message-Id: <20120210084256.16544.12640.malone@soybean.canonical.com> Errors-To: bounces@canonical.com Subject: [Qemu-devel] [Bug 824650] Re: Latest GIT assert error in arp_table.c Reply-To: Bug 824650 <824650@bugs.launchpad.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org slirp/ip_icmp.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/slirp/ip_icmp.c b/slirp/ip_icmp.c index 4b43994..5dbf21d 100644 --- a/slirp/ip_icmp.c +++ b/slirp/ip_icmp.c @@ -262,6 +262,11 @@ icmp_error(struct mbuf *msrc, u_char type, u_char code= , int minsize, #endif if(ip->ip_off & IP_OFFMASK) goto end_error; /* Only reply to fragment= 0 */ = + /* Do not reply to source-only IPs */ + if ((ip->ip_src.s_addr & htonl(~(0xf << 28))) =3D=3D 0) { + goto end_error; + } + shlen=3Dip->ip_hl << 2; s_ip_len=3Dip->ip_len; if(ip->ip_p =3D=3D IPPROTO_ICMP) { Fix seem to work. No crashes so far. Thanks a lot to Jan Kiszka ** Changed in: qemu Status: New =3D> Fix Committed ** Changed in: qemu Status: Fix Committed =3D> Fix Released -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/824650 Title: Latest GIT assert error in arp_table.c Status in QEMU: Fix Released Bug description: The latest git version of qemu (commit 8cc7c3952d4d0a681d8d4c3ac89a206a5bfd7f00) crashes after a few minutes. All was fine up to a few days ago. This is wth both x86 and sparc emulation, on an x86_64 host. e.g. qemu-system-sparc -drive file=3Dnetbsd5.0.2-sparc,index=3D0,media=3Ddisk,cache=3Dunsafe -m 256 -bo= ot c -nographic -redir tcp:2232::22: qemu-system-sparc: slirp/arp_table.c:75: arp_table_search: Assertion `(ip_addr & (__extension__ ({ register unsigned int __v, __x =3D (~(0xf << 28)); if (__builtin_constant_p (__x)) __v =3D ((((__x) & 0xff000000) >> 24) | (((__x) & 0x00ff0000) >> 8) | (((__x) & 0x0000ff00) << 8) | (((__x) & 0x000000ff) << 24)); else __asm__ ("bswap %0" : "=3Dr" (__v) : "0" (__x)); __v; }))) !=3D 0' failed. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/824650/+subscriptions