From: Amit Shah <amit.shah@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, johnstul@us.ibm.com,
riel@redhat.com, avi@redhat.com
Subject: Re: x86: kvmclock: abstract save/restore sched_clock_state
Date: Mon, 13 Feb 2012 18:26:17 +0530 [thread overview]
Message-ID: <20120213125617.GB4500@amit.redhat.com> (raw)
In-Reply-To: <20120210123337.GB11137@amt.cnet>
On (Fri) 10 Feb 2012 [10:33:37], Marcelo Tosatti wrote:
> On Fri, Feb 10, 2012 at 10:32:16AM -0200, Marcelo Tosatti wrote:
> > On Fri, Feb 10, 2012 at 03:32:11PM +0530, Amit Shah wrote:
> > > On (Thu) 09 Feb 2012 [16:13:29], Igor Mammedov wrote:
> > >
> > > > Stalls are probably caused by uninitialized percpu hv_clock, with
> > > > following patch I don't see stalls. Although I might be just lucky.
> > > > http://git.kernel.org/?p=virt/kvm/kvm.git;a=commit;h=e2971ac7e1d186af059e088d305496c5cb47d487
> > >
> > > Your commit does make things better, I don't see any stalls on the
> > > first resume.
> > >
> > > However, a subsequent s4 causes the stall to re-appear on resume, and
> > > this time there are no stall messages; the kernel just sits there
> > > spinning on something. I've not found the solution to this one yet (I
> > > had a commit similar to Marcelo's in the works, which got me to the
> > > previous works-but-stalls behaviour).
> >
> > I cannot reproduce it here. Suspend/resume are operating normally after
> > several iterations. Igor do you see anything similar?
> >
> > Amit, can you please enable CONFIG_PRINTK_TIME=y and post a full dmesg
> > (both during suspend and also the new kernel during resume).
>
> Also is it reproducible with UP guest?
Yes, it is.
Amit
next prev parent reply other threads:[~2012-02-13 12:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 21:05 x86: kvmclock: abstract save/restore sched_clock_state Marcelo Tosatti
2012-02-08 10:53 ` Igor Mammedov
2012-02-09 12:27 ` Amit Shah
2012-02-09 15:13 ` Igor Mammedov
2012-02-10 10:02 ` Amit Shah
2012-02-10 10:11 ` Igor Mammedov
2012-02-10 10:23 ` Amit Shah
2012-02-10 12:32 ` Marcelo Tosatti
2012-02-10 12:33 ` Marcelo Tosatti
2012-02-10 12:43 ` Igor Mammedov
2012-02-13 12:46 ` Amit Shah
2012-02-13 12:56 ` Amit Shah [this message]
2012-02-10 13:18 ` Amit Shah
2012-02-10 20:58 ` Igor Mammedov
2012-02-13 12:39 ` Amit Shah
2012-02-13 13:07 ` x86: kvmclock: abstract save/restore sched_clock_state (v2) Marcelo Tosatti
2012-02-13 15:20 ` Igor Mammedov
2012-02-13 15:52 ` Marcelo Tosatti
2012-02-15 10:28 ` Avi Kivity
2012-02-13 15:45 ` [PATCH RFC] pvclock: Make pv_clock more robust and fixup it if overflow happens Igor Mammedov
2012-02-13 17:48 ` Marcelo Tosatti
2012-02-13 18:15 ` Igor Mammedov
2012-02-13 16:26 ` x86: kvmclock: abstract save/restore sched_clock_state (v2) Amit Shah
2012-03-01 9:58 ` x86: kvmclock: abstract save/restore sched_clock_state Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120213125617.GB4500@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=imammedo@redhat.com \
--cc=johnstul@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.