All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Richard Weinberger <richard@nod.at>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, eric.dumazet@gmail.com,
	jengelh@medozas.de, rostedt@goodmis.org, basti@b-bl.de
Subject: Re: [PATCH 4/4] Netfilter: xt_LOG: Implement ring buffer support
Date: Tue, 14 Feb 2012 01:11:23 +0100	[thread overview]
Message-ID: <20120214001123.GA24194@1984> (raw)
In-Reply-To: <1328911856-19260-7-git-send-email-richard@nod.at>

On Fri, Feb 10, 2012 at 11:10:56PM +0100, Richard Weinberger wrote:
> This patch introduces NETFILTER_XT_TARGET_LOG_RING.
> It allows logging into various ring buffers which are
> represented as pipe-like files in /proc/net/netfilter/xt_LOG_ring/.
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  include/linux/netfilter/xt_LOG.h    |   13 +-
>  include/net/netfilter/nf_log.h      |    1 +
>  include/net/netfilter/xt_log_ring.h |   24 ++

Could merge xt_log_ring.h with xt_log.h?

>  net/netfilter/Kconfig               |   13 +
>  net/netfilter/xt_LOG.c              |  642 ++++++++++++++++++++++++++++++++++-
>  5 files changed, 674 insertions(+), 19 deletions(-)
>  create mode 100644 include/net/netfilter/xt_log_ring.h
> 
> diff --git a/include/linux/netfilter/xt_LOG.h b/include/linux/netfilter/xt_LOG.h
> index cac0790..d84710c 100644
> --- a/include/linux/netfilter/xt_LOG.h
> +++ b/include/linux/netfilter/xt_LOG.h
> @@ -8,7 +8,8 @@
>  #define XT_LOG_UID		0x08	/* Log UID owning local socket */
>  #define XT_LOG_NFLOG		0x10	/* Unsupported, don't reuse */
>  #define XT_LOG_MACDECODE	0x20	/* Decode MAC header */
> -#define XT_LOG_MASK		0x2f
> +#define XT_LOG_ADD_TIMESTAMP	0x40	/* Add a timestamp */

Please, I'd appreciate if you can split this timestamp support in a
separated patch.

Thanks.

  reply	other threads:[~2012-02-14  0:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10 22:10 [PATCH v5] Merge ipt_LOG and ip6t_LOG, add ring bufffer support Richard Weinberger
2012-02-10 22:10 ` [PATCH 1/2] iptables: Merge libip6t_LOG and libipt_LOG into libxt_LOG Richard Weinberger
2012-02-25 13:38   ` Pablo Neira Ayuso
2012-02-28 16:06     ` Richard Weinberger
2012-02-28 16:15       ` Dave Taht
2012-02-28 16:15         ` Dave Taht
2012-02-28 22:54         ` Pablo Neira Ayuso
2012-02-10 22:10 ` [PATCH 1/4] Netfilter: Merge ipt_LOG and ip6_LOG into xt_LOG Richard Weinberger
2012-02-13 23:56   ` Pablo Neira Ayuso
2012-02-10 22:10 ` [PATCH 2/2] iptables: xt_LOG: Add ring buffer support Richard Weinberger
2012-02-10 22:10 ` [PATCH 2/4] ring_buffer: Export for_each_buffer_cpu() Richard Weinberger
2012-02-14  0:05   ` Pablo Neira Ayuso
2012-02-10 22:10 ` [PATCH 3/4] xt_log: Make printk() in sb_close() optional Richard Weinberger
2012-02-14  0:12   ` Pablo Neira Ayuso
2012-02-10 22:10 ` [PATCH 4/4] Netfilter: xt_LOG: Implement ring buffer support Richard Weinberger
2012-02-14  0:11   ` Pablo Neira Ayuso [this message]
2012-02-14  0:12     ` Richard Weinberger
  -- strict thread matches above, loose matches on Subject: below --
2012-02-09 21:54 [PATCH v4] Merge ipt_LOG and ip6t_LOG, add ring bufffer support Richard Weinberger
2012-02-09 21:54 ` [PATCH 4/4] Netfilter: xt_LOG: Implement ring buffer support Richard Weinberger
2012-02-05  0:14 [PATCH v3] Merge ipt_LOG and ip6t_LOG, add ring bufffer support Richard Weinberger
2012-02-05  0:14 ` [PATCH 4/4] Netfilter: xt_LOG: Implement ring buffer support Richard Weinberger
2012-02-08 10:29   ` Pablo Neira Ayuso
2012-02-08 10:40     ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120214001123.GA24194@1984 \
    --to=pablo@netfilter.org \
    --cc=basti@b-bl.de \
    --cc=eric.dumazet@gmail.com \
    --cc=jengelh@medozas.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=richard@nod.at \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.