From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Wed, 15 Feb 2012 22:25:00 -0500 Subject: [U-Boot] [PATCH v3 7/8] sandbox: Add flags for open() call In-Reply-To: References: <1327301333-30776-1-git-send-email-sjg@chromium.org> <201201241645.12414.vapier@gentoo.org> Message-ID: <201202152225.01648.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 15 February 2012 17:58:35 Simon Glass wrote: > On Tue, Jan 24, 2012 at 1:45 PM, Mike Frysinger wrote: > > On Monday 23 January 2012 01:48:52 Simon Glass wrote: > >> -/* > >> - * Operating System Interface > >> - * > >> - * This provides access to useful OS routines from the sandbox > >> architecture - */ > >> +struct sandbox_state; > > > > looks like unrelated stuff got squished into here > > We need to declare the struct. The comment change is because you said > we should put the purpose of the file at the top, and I thought it > didn't really warrant a new commit? i meant that adding the struct forward decl in this commit doesn't make sense. it should be part of one of the sandbox state patches. deleting the comment is fine, but the changelog should mention that this was on purpose and not just an accident. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: