From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756435Ab2BOXrj (ORCPT ); Wed, 15 Feb 2012 18:47:39 -0500 Received: from mail.betterlinux.com ([199.58.199.50]:59178 "EHLO mail.betterlinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756340Ab2BOXrg (ORCPT ); Wed, 15 Feb 2012 18:47:36 -0500 X-DKIM: OpenDKIM Filter v2.4.1 mail.betterlinux.com C4BC9821A9 Date: Thu, 16 Feb 2012 00:47:24 +0100 From: Andrea Righi To: Arun Sharma Cc: Andrew Morton , Minchan Kim , Peter Zijlstra , Johannes Weiner , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Rik van Riel , Hugh Dickins , Alexander Viro , Shaohua Li , =?iso-8859-1?Q?P=E1draig?= Brady , John Stultz , Jerry James , Julius Plenz , linux-mm , linux-fsdevel@vger.kernel.org, LKML Subject: Re: [PATCH v5 3/3] fadvise: implement POSIX_FADV_NOREUSE Message-ID: <20120215234724.GA21685@thinkpad> References: <1329006098-5454-1-git-send-email-andrea@betterlinux.com> <1329006098-5454-4-git-send-email-andrea@betterlinux.com> <20120215233537.GA20724@dev3310.snc6.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120215233537.GA20724@dev3310.snc6.facebook.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2012 at 03:35:37PM -0800, Arun Sharma wrote: > On Sun, Feb 12, 2012 at 01:21:38AM +0100, Andrea Righi wrote: > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index 386da09..624a73e 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -9,6 +9,7 @@ > > #include > > #include > > #include > > +#include > > #include > > fs.h is an exported header file, whereas kinterval.h is not. So this > fails scripts/header_check.pl. > > I used the workaround below. > > -Arun > > diff --git a/fs/inode.c b/fs/inode.c > index d27dbee..1335a5f 100644 > --- a/fs/inode.c > +++ b/fs/inode.c > @@ -26,6 +26,7 @@ > #include > #include > #include /* for inode_has_buffers */ > +#include > #include "internal.h" > > /* > @@ -279,7 +280,7 @@ void address_space_init_once(struct address_space *mapping) > spin_lock_init(&mapping->private_lock); > INIT_RAW_PRIO_TREE_ROOT(&mapping->i_mmap); > INIT_LIST_HEAD(&mapping->i_mmap_nonlinear); > - INIT_KINTERVAL_TREE_ROOT(&mapping->nocache_tree); > + INIT_KINTERVAL_TREE_ROOT((struct rb_root *) &mapping->nocache_tree); > rwlock_init(&mapping->nocache_lock); > } > EXPORT_SYMBOL(address_space_init_once); > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 74b6a97..b4e45e6 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -9,7 +9,6 @@ > #include > #include > #include > -#include > #include > > /* > @@ -656,7 +655,7 @@ struct address_space { > spinlock_t private_lock; /* for use by the address_space */ > struct list_head private_list; /* ditto */ > struct address_space *assoc_mapping; /* ditto */ > - struct rb_root nocache_tree; /* noreuse cache range tree */ > + void *nocache_tree; /* noreuse cache range tree */ > rwlock_t nocache_lock; /* protect the nocache_tree */ > } __attribute__((aligned(sizeof(long)))); > /* mmh.. a forward declaration of rb_root in fs.h shouldn't be better than this? Thanks, -Andrea From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrea Righi Subject: Re: [PATCH v5 3/3] fadvise: implement POSIX_FADV_NOREUSE Date: Thu, 16 Feb 2012 00:47:24 +0100 Message-ID: <20120215234724.GA21685@thinkpad> References: <1329006098-5454-1-git-send-email-andrea@betterlinux.com> <1329006098-5454-4-git-send-email-andrea@betterlinux.com> <20120215233537.GA20724@dev3310.snc6.facebook.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Minchan Kim , Peter Zijlstra , Johannes Weiner , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Rik van Riel , Hugh Dickins , Alexander Viro , Shaohua Li , =?iso-8859-1?Q?P=E1draig?= Brady , John Stultz , Jerry James , Julius Plenz , linux-mm , linux-fsdevel@vger.kernel.org, LKML To: Arun Sharma Return-path: Content-Disposition: inline In-Reply-To: <20120215233537.GA20724@dev3310.snc6.facebook.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Feb 15, 2012 at 03:35:37PM -0800, Arun Sharma wrote: > On Sun, Feb 12, 2012 at 01:21:38AM +0100, Andrea Righi wrote: > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index 386da09..624a73e 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -9,6 +9,7 @@ > > #include > > #include > > #include > > +#include > > #include > > fs.h is an exported header file, whereas kinterval.h is not. So this > fails scripts/header_check.pl. > > I used the workaround below. > > -Arun > > diff --git a/fs/inode.c b/fs/inode.c > index d27dbee..1335a5f 100644 > --- a/fs/inode.c > +++ b/fs/inode.c > @@ -26,6 +26,7 @@ > #include > #include > #include /* for inode_has_buffers */ > +#include > #include "internal.h" > > /* > @@ -279,7 +280,7 @@ void address_space_init_once(struct address_space *mapping) > spin_lock_init(&mapping->private_lock); > INIT_RAW_PRIO_TREE_ROOT(&mapping->i_mmap); > INIT_LIST_HEAD(&mapping->i_mmap_nonlinear); > - INIT_KINTERVAL_TREE_ROOT(&mapping->nocache_tree); > + INIT_KINTERVAL_TREE_ROOT((struct rb_root *) &mapping->nocache_tree); > rwlock_init(&mapping->nocache_lock); > } > EXPORT_SYMBOL(address_space_init_once); > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 74b6a97..b4e45e6 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -9,7 +9,6 @@ > #include > #include > #include > -#include > #include > > /* > @@ -656,7 +655,7 @@ struct address_space { > spinlock_t private_lock; /* for use by the address_space */ > struct list_head private_list; /* ditto */ > struct address_space *assoc_mapping; /* ditto */ > - struct rb_root nocache_tree; /* noreuse cache range tree */ > + void *nocache_tree; /* noreuse cache range tree */ > rwlock_t nocache_lock; /* protect the nocache_tree */ > } __attribute__((aligned(sizeof(long)))); > /* mmh.. a forward declaration of rb_root in fs.h shouldn't be better than this? Thanks, -Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org