From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42930)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S11jF-0006Yv-UV
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 15:26:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S11jE-0002jE-UT
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 15:26:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:18841)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S11jE-0002j8-Mn
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 15:26:56 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1OKQtx0017835
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 24 Feb 2012 15:26:55 -0500
Date: Fri, 24 Feb 2012 18:26:55 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120224182655.7594983c@doriath.home>
In-Reply-To: <4F47E7A1.1020200@redhat.com>
References: <1329930815-7995-1-git-send-email-fsimonce@redhat.com>
	<1330102144-14491-2-git-send-email-fsimonce@redhat.com>
	<20120224170143.78f55d3e@doriath.home>
	<4F47E7A1.1020200@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and
 blockdev-migrate commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, Federico Simoncelli <fsimonce@redhat.com>, pbonzini@redhat.com

On Fri, 24 Feb 2012 12:40:17 -0700
Eric Blake <eblake@redhat.com> wrote:

> On 02/24/2012 12:01 PM, Luiz Capitulino wrote:
> 
> >> +    BlockDriver *drv;
> >> +    int i, j, escape;
> >> +    char new_filename[2048], *filename;
> > 
> > I'd use PATH_MAX for new_filename's size.
> 
> PATH_MAX need not be defined (and on Hurd, it intentionally is not
> defined); or might be so huge as to be useless.

Aren't those extreme cases? PATH_MAX is a standard define and is used in
QEMU in several places. If it's not good here, it shouldn't be good anywhere.