From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sun, 26 Feb 2012 23:33:01 -0500 Subject: [U-Boot] [PATCH 05/15] common/main.c: Fix function readline In-Reply-To: <7289416.t84EK1VC5H@pali-elitebook> References: <1778406.ezGto4lKnu@pali-elitebook> <201201061515.31097.vapier@gentoo.org> <7289416.t84EK1VC5H@pali-elitebook> Message-ID: <201202262333.03150.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 07 January 2012 03:51:16 Pali Roh?r wrote: > On Friday 06 January 2012 15:15:29 Mike Frysinger wrote: > > On Sunday 18 December 2011 16:34:01 Pali Roh?r wrote: > > > * Ignore ANSI escape codes for moving cursor, which are generated by > > > > > > keyboard > > > > this probably should be behind an appropriate CONFIG knob. i don't think > > this is relevant to serial users (which are the majority of boards). > > I think this is also relevant to serial console too. I tried serial console > (over USB) with Nokia N900 on computer (ANSI terminal) and if I pressed > cursor key (UP/DOWN/LEFT/RIGHT) it moved cursor. But in readline function > buffer was stored ANSI sequence. So when I pressed ENTER, u-boot tried to > execute that buffer and showed me error. But it showed error message > something like unknown command . ansi_seq was recognized in ansi > terminal on computer and it garbaged output. (for example if asn_seq was > move up, error message continued on previous line...) > > This patch ignore ansi codes which can be generated by curosor keys, so > there will not be that bad error messages... do you have CONFIG_CMDLINE_EDITING enabled ? arrow keys work just fine when that's enabled, and if it isn't, then i think it's expected behavior that pressing the arrow keys would generate "junk" that u-boot wouldn't interpret. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: