All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/8] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota
Date: Sun, 26 Feb 2012 19:59:41 -0600	[thread overview]
Message-ID: <20120227015941.GI7762@sgi.com> (raw)
In-Reply-To: <20120220022903.488870885@bombadil.infradead.org>

Hi Christoph,

On Sun, Feb 19, 2012 at 09:28:16PM -0500, Christoph Hellwig wrote:
> The is no good reason to have these two separate, and for the next change
> we would need the full struct xfs_dquot in xfs_qm_export_dquot, so better
> just fold the code now instead of changing it spuriously.
> 
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

I should have replied to this patch, not the older rev.

I have a question about the error code, now we're not mapping errors to
EFAULT and we used do... which is correct?

Thanks,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-02-27  1:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-20  2:28 [PATCH 0/8] quota updates, V3 Christoph Hellwig
2012-02-20  2:28 ` [PATCH 1/8] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota Christoph Hellwig
2012-02-27  1:59   ` Ben Myers [this message]
2012-02-27 17:17     ` Christoph Hellwig
2012-02-27 17:23       ` Ben Myers
2012-02-28  3:27         ` Christoph Hellwig
2012-02-29 17:40           ` Ben Myers
2012-02-20  2:28 ` [PATCH 2/8] xfs: include reservations in quota reporting Christoph Hellwig
2012-02-29 19:37   ` Ben Myers
2012-02-20  2:28 ` [PATCH 3/8] quota: make Q_XQUOTASYNC a noop Christoph Hellwig
2012-02-29 20:00   ` Ben Myers
2012-02-20  2:28 ` [PATCH 4/8] xfs: use common code for quota statistics Christoph Hellwig
2012-02-20 21:33   ` Dave Chinner
2012-02-20 21:50     ` Christoph Hellwig
2012-02-21  1:48   ` [PATCH 4/8 v2] " Christoph Hellwig
2012-02-21  4:41     ` Dave Chinner
2012-03-12 17:55     ` Ben Myers
2012-03-13  8:42       ` Christoph Hellwig
2012-03-13 15:27         ` Ben Myers
2012-03-13 21:40           ` Dave Chinner
2012-03-14  2:34             ` Nathan Scott
2012-03-14  5:03               ` Dave Chinner
2012-02-20  2:28 ` [PATCH 5/8] xfs: per-filesystem dquot LRU lists Christoph Hellwig
2012-02-20 22:08   ` Dave Chinner
2012-03-12 20:37   ` Ben Myers
2012-02-20  2:28 ` [PATCH 6/8] xfs: use per-filesystem radix trees for dquot lookup Christoph Hellwig
2012-02-20  2:28 ` [PATCH 7/8] xfs: remove the per-filesystem list of dquots Christoph Hellwig
2012-02-20 22:15   ` Dave Chinner
2012-02-20 22:19     ` Christoph Hellwig
2012-02-28  3:31   ` [PATCH 7/8 v2] " Christoph Hellwig
2012-02-20  2:28 ` [PATCH 8/8] xfs: remove the global xfs_Gqm structure Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120227015941.GI7762@sgi.com \
    --to=bpm@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.