All of lore.kernel.org
 help / color / mirror / Atom feed
From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/raid/raid.c
Date: 27 Feb 2012 10:15:11 -0000	[thread overview]
Message-ID: <20120227101511.17477.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac at sourceware.org	2012-02-27 10:15:08

Modified files:
	.              : WHATS_NEW 
	lib/raid       : raid.c 

Log message:
	Test seg pointer for non-null
	
	As the function accepts NULL for 'seg' parameter,
	check for it before dereference.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2313&r2=1.2314
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/raid/raid.c.diff?cvsroot=lvm2&r1=1.15&r2=1.16

--- LVM2/WHATS_NEW	2012/02/27 10:05:35	1.2313
+++ LVM2/WHATS_NEW	2012/02/27 10:15:08	1.2314
@@ -1,5 +1,6 @@
 Version 2.02.94 - 
-====================================                       
+====================================
+  Test seg pointer for non-null it in raid_target_percent error path.
   Check for errors in _init_tags() during config loading.
   Always check result of _set_vg_name() in lvcreate.
   Drop unused call to uname() during clvmd initialization.
--- LVM2/lib/raid/raid.c	2012/02/13 20:13:40	1.15
+++ LVM2/lib/raid/raid.c	2012/02/27 10:15:08	1.16
@@ -230,7 +230,7 @@
 	if (!pos || (sscanf(pos, "%" PRIu64 "/%" PRIu64 "%n",
 			    &numerator, &denominator, &i) != 2)) {
 		log_error("Failed to parse %s status fraction: %s",
-			  seg->segtype->name, params);
+			  (seg) ? seg->segtype->name : "segment", params);
 		return 0;
 	}
 



                 reply	other threads:[~2012-02-27 10:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120227101511.17477.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.