From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/lib format_text/archiver.c metadata/metad ...
Date: 27 Feb 2012 11:36:00 -0000 [thread overview]
Message-ID: <20120227113600.31260.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2012-02-27 11:36:00
Modified files:
lib/format_text: archiver.c
lib/metadata : metadata.c
Log message:
Add stack traces for lock_vol failures
Adding at least stack traces with some FIXMEs for cases,
where we might want to do something cleaver - maybe fail command
or give user hints something is not going well ?
For remote_backup is stack probably 'good' enough for now.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/archiver.c.diff?cvsroot=lvm2&r1=1.50&r2=1.51
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.487&r2=1.488
--- LVM2/lib/format_text/archiver.c 2012/02/12 23:01:19 1.50
+++ LVM2/lib/format_text/archiver.c 2012/02/27 11:35:59 1.51
@@ -244,7 +244,8 @@
int backup(struct volume_group *vg)
{
if (vg_is_clustered(vg))
- remote_backup_metadata(vg);
+ if (!remote_backup_metadata(vg))
+ stack;
return backup_locally(vg);
}
--- LVM2/lib/metadata/metadata.c 2012/02/27 09:51:31 1.487
+++ LVM2/lib/metadata/metadata.c 2012/02/27 11:36:00 1.488
@@ -2708,7 +2708,8 @@
if (cache_updated) {
/* Instruct remote nodes to upgrade cached metadata. */
- remote_commit_cached_metadata(vg);
+ if (!remote_commit_cached_metadata(vg))
+ stack; // FIXME: What should we do?
/*
* We need to clear old_name after a successful commit.
* The volume_group structure could be reused later.
@@ -2741,7 +2742,8 @@
log_error("Attempt to drop cached metadata failed "
"after reverted update for VG %s.", vg->name);
- remote_revert_cached_metadata(vg);
+ if (!remote_revert_cached_metadata(vg))
+ stack; // FIXME: What should we do?
}
struct _vg_read_orphan_baton {
next reply other threads:[~2012-02-27 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 11:36 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-21 12:11 LVM2/lib format_text/archiver.c metadata/metad prajnoha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227113600.31260.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.