All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bhelgaas@google.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	linux-pci@vger.kernel.org,
	Svante Signell <svante.signell@telia.com>
Subject: [PATCH] x86/PCI: use host bridge _CRS info on MSI MS-7253
Date: Tue, 28 Feb 2012 11:51:10 -0700	[thread overview]
Message-ID: <20120228185110.16227.58753.stgit@bhelgaas.mtv.corp.google.com> (raw)

From: Jonathan Nieder <jrnieder@gmail.com>

In the spirit of commit 29cf7a30f8a0 ("x86/PCI: use host bridge _CRS
info on ASUS M2V-MX SE"), this DMI quirk turns on "pci_use_crs" by
default on a board that needs it.

This fixes boot failures and oopses introduced in 3e3da00c01d0
("x86/pci: AMD one chain system to use pci read out res").  The quirk
is quite targetted (to a specific board and BIOS version) for two
reasons:

 (1) to emphasize that this method of tackling the problem one quirk
     at a time is a little insane

 (2) to give BIOS vendors an opportunity to use simpler tables and
     allow us to return to generic behavior (whatever that happens to
     be) with a later BIOS update

In other words, I am not at all happy with having quirks like this.
But it is even worse for the kernel not to work out of the box on
these machines, so...

Reference: https://bugzilla.kernel.org/show_bug.cgi?id=42619
Reported-by: Svante Signell <svante.signell@telia.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 arch/x86/pci/acpi.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c
index a312e76..2c5cbdb 100644
--- a/arch/x86/pci/acpi.c
+++ b/arch/x86/pci/acpi.c
@@ -60,6 +60,17 @@ static const struct dmi_system_id pci_use_crs_table[] __initconst = {
 			DMI_MATCH(DMI_BIOS_VENDOR, "American Megatrends Inc."),
 		},
 	},
+	/* https://bugzilla.kernel.org/show_bug.cgi?id=42619 */
+	{
+		.callback = set_use_crs,
+		.ident = "MSI MS-7253",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
+			DMI_MATCH(DMI_BOARD_NAME, "MS-7253"),
+			DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies, LTD"),
+			DMI_MATCH(DMI_BIOS_VERSION, "V1.6"),
+		},
+	},
 
 	/* Now for the blacklist.. */
 


             reply	other threads:[~2012-02-28 18:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 18:51 Bjorn Helgaas [this message]
2012-02-28 18:55 ` [PATCH] x86/PCI: use host bridge _CRS info on MSI MS-7253 Bjorn Helgaas
2012-02-28 19:09 ` Jesse Barnes
2012-02-28 21:31 ` [PATCH] x86/PCI: do not tie MSI MS-7253 use_crs quirk to BIOS version Jonathan Nieder
2012-02-28 21:35   ` Bjorn Helgaas
2012-03-01 18:57   ` Jesse Barnes
2012-03-02  4:25     ` Jonathan Nieder
2012-04-09 23:47       ` [3.0.y, 3.2.y, 3.3.y] " Jonathan Nieder
2012-04-09 23:50         ` Jonathan Nieder
2012-04-10 23:00         ` Greg Kroah-Hartman
2012-04-11  1:41           ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120228185110.16227.58753.stgit@bhelgaas.mtv.corp.google.com \
    --to=bhelgaas@google.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jrnieder@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=svante.signell@telia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.