From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758645Ab2CAL1j (ORCPT ); Thu, 1 Mar 2012 06:27:39 -0500 Received: from mail.us.es ([193.147.175.20]:58399 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757649Ab2CAL1i (ORCPT ); Thu, 1 Mar 2012 06:27:38 -0500 Date: Thu, 1 Mar 2012 12:27:32 +0100 From: Pablo Neira Ayuso To: Richard Weinberger Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, eric.dumazet@gmail.com, jengelh@medozas.de, rostedt@goodmis.org Subject: Re: [PATCH 1/4] Netfilter: Merge ipt_LOG and ip6_LOG into xt_LOG Message-ID: <20120301112732.GA6806@1984> References: <1328400892-22409-1-git-send-email-richard@nod.at> <1328400892-22409-3-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1328400892-22409-3-git-send-email-richard@nod.at> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 05, 2012 at 01:14:48AM +0100, Richard Weinberger wrote: > ipt_LOG and ip6_LOG have a lot of common code, merge them > to reduce duplicate code. > > Signed-off-by: Richard Weinberger While testing this in my master branch I noticed one problem: IN=wlan0 OUT= MAC=xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx SRC=213.150.61.61 DST=192.168.1.133 LEN=40 TOS=0x00 PREC=0x00 TTL=117 ID=10539 DF PROTO=TCP SPT=80 DPT=49013 WINDOW=0 RES=0x00 ACK RST URGP=0 PROTO=UDPLITE SPT=80 DPT=49013 LEN=45843 PROTO=ICMP TYPE=0 CODE=80 ID=45843 SEQ=48576 While merging ipt_LOG and ip6t_LOG, you introduced some bug that corrupts the log line. Note the extra PROTO=, I don't have any UDPLITE traffic here. Looks like a missing break in one switch. Would you send me a patch to fix this? Thank you.