From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758930Ab2CBQtt (ORCPT ); Fri, 2 Mar 2012 11:49:49 -0500 Received: from mail.us.es ([193.147.175.20]:55223 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758860Ab2CBQtr (ORCPT ); Fri, 2 Mar 2012 11:49:47 -0500 Date: Fri, 2 Mar 2012 17:49:45 +0100 From: Pablo Neira Ayuso To: Richard Weinberger Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, eric.dumazet@gmail.com, jengelh@medozas.de, rostedt@goodmis.org Subject: Re: [PATCH 1/4] Netfilter: Merge ipt_LOG and ip6_LOG into xt_LOG Message-ID: <20120302164945.GA13723@1984> References: <1328400892-22409-1-git-send-email-richard@nod.at> <1328400892-22409-3-git-send-email-richard@nod.at> <20120301112732.GA6806@1984> <4F4FEC83.6090504@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F4FEC83.6090504@nod.at> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 01, 2012 at 10:39:15PM +0100, Richard Weinberger wrote: > Am 01.03.2012 12:27, schrieb Pablo Neira Ayuso: > > While merging ipt_LOG and ip6t_LOG, you introduced some bug that > > corrupts the log line. Note the extra PROTO=, I don't have any UDPLITE > > traffic here. > > > > Looks like a missing break in one switch. > > I got confused by my own logic. :-\ > Does the attached patch fix the issue? > It's based on "Netfilter: xt_LOG: Add timestamp support" This patch lacks of description. If you don't make it myself, I have to do it for you :-( Please, send me patches following the standard format next time.