From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 06 Mar 2012 21:33:58 +0100 Subject: [U-Boot] [PATCH v3] net: allow setting env enetaddr from net device setting In-Reply-To: <4F566D05.5020809@gmail.com> References: <1323199478-21001-1-git-send-email-robherring2@gmail.com> <1328138854-28612-1-git-send-email-robherring2@gmail.com> <20120306193011.D9DF5202D76@gemini.denx.de> <4F566D05.5020809@gmail.com> Message-ID: <20120306203358.D4B50202D76@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Rob, In message <4F566D05.5020809@gmail.com> you wrote: > > >> +3. Write value to environment if setup in struct eth_device->enetaddr by driver > >> + initialize() function. Give priority to the value in the environment if a > >> + conflict. > > > > Sorry, but this description is not correct. You say here that the > > environment variable should always be written, but this is not the > > case. Only if it does not exist it shall be set. If it exists, it > > shall only be read, and in case of inconsistencies a warning shall be > > printed. > > How about this: > > 3. Always use the value in the environment if there is a conflict. If > the environment variable is not set and the driver initialized struct > eth_device->enetaddr, then print a warning and set the environment > variable to initialized by the driver. I find you make it difficult to read without need by explaining it backwards. The environment variable will be compared to the driver initialized struct eth_device->enetaddr. If they differ, a warning is printed, an the environment variable will be used unchanged. If the environment variable is not set, it will be initialized from eth_device->enetaddr, and a warning will be printed. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Ninety-Ninety Rule of Project Schedules: The first ninety percent of the task takes ninety percent of the time, and the last ten percent takes the other ninety percent.