From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5KrM-0000uy-9C for qemu-devel@nongnu.org; Wed, 07 Mar 2012 12:41:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5KrK-0007lk-Hg for qemu-devel@nongnu.org; Wed, 07 Mar 2012 12:41:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5KrK-0007lc-95 for qemu-devel@nongnu.org; Wed, 07 Mar 2012 12:41:06 -0500 Date: Wed, 7 Mar 2012 14:41:01 -0300 From: Luiz Capitulino Message-ID: <20120307144101.0c2b049e@doriath.home> In-Reply-To: <1330444295-8859-3-git-send-email-stefano.stabellini@eu.citrix.com> References: <1330444295-8859-3-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RESEND v5 3/6] Set runstate to INMIGRATE earlier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: jan.kiszka@siemens.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, avi@redhat.com On Tue, 28 Feb 2012 15:51:32 +0000 Stefano Stabellini wrote: > Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. > > Signed-off-by: Stefano Stabellini Would be nice to explain why, but I suggested this myself so: Acked-by: Luiz Capitulino > --- > vl.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/vl.c b/vl.c > index 5b2b84c..341775b 100644 > --- a/vl.c > +++ b/vl.c > @@ -3099,6 +3099,7 @@ int main(int argc, char **argv, char **envp) > break; > case QEMU_OPTION_incoming: > incoming = optarg; > + runstate_set(RUN_STATE_INMIGRATE); > break; > case QEMU_OPTION_nodefaults: > default_serial = 0; > @@ -3596,7 +3597,6 @@ int main(int argc, char **argv, char **envp) > } > > if (incoming) { > - runstate_set(RUN_STATE_INMIGRATE); > int ret = qemu_start_incoming_migration(incoming); > if (ret < 0) { > fprintf(stderr, "Migration failed. Exit code %s(%d), exiting.\n", From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luiz Capitulino Subject: Re: [PATCH RESEND v5 3/6] Set runstate to INMIGRATE earlier Date: Wed, 7 Mar 2012 14:41:01 -0300 Message-ID: <20120307144101.0c2b049e@doriath.home> References: <1330444295-8859-3-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1330444295-8859-3-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefano Stabellini Cc: jan.kiszka@siemens.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, avi@redhat.com List-Id: xen-devel@lists.xenproject.org On Tue, 28 Feb 2012 15:51:32 +0000 Stefano Stabellini wrote: > Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. > > Signed-off-by: Stefano Stabellini Would be nice to explain why, but I suggested this myself so: Acked-by: Luiz Capitulino > --- > vl.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/vl.c b/vl.c > index 5b2b84c..341775b 100644 > --- a/vl.c > +++ b/vl.c > @@ -3099,6 +3099,7 @@ int main(int argc, char **argv, char **envp) > break; > case QEMU_OPTION_incoming: > incoming = optarg; > + runstate_set(RUN_STATE_INMIGRATE); > break; > case QEMU_OPTION_nodefaults: > default_serial = 0; > @@ -3596,7 +3597,6 @@ int main(int argc, char **argv, char **envp) > } > > if (incoming) { > - runstate_set(RUN_STATE_INMIGRATE); > int ret = qemu_start_incoming_migration(incoming); > if (ret < 0) { > fprintf(stderr, "Migration failed. Exit code %s(%d), exiting.\n",