From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 7 Mar 2012 15:18:53 +0100 Subject: [U-Boot] [PATCH 15/25] SPEAr: Enable autoneg for ethernet In-Reply-To: <1331121854-20494-16-git-send-email-amit.virdi@st.com> References: <1331121854-20494-1-git-send-email-amit.virdi@st.com> <1331121854-20494-16-git-send-email-amit.virdi@st.com> Message-ID: <201203071518.53629.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 07 March 2012 13:04:04 Amit Virdi wrote: > From: Shiraz Hashim > > The linux-2.6.37 base port has few problems with nfs boot. The boot > fails while getting timeout on attempting to mount root file system. > This helps the ethernet to bring up faster in linux boot thus avoiding > the time out. > Besides, it was reported that few phys on SPEAr board are failing in > certain network conditions which is avoided by enabling autonegotiation. > See issue #115943 in global bug tracker. Hmmm. This sounds like a problem in the Linux network/PHY code then. Which needs to get fixed there instead of changing something here in U-Boot. Please think about situations where the ethernet driver is not called at all in U- Boot (booting from NOR/NAND). With my changes to defer the ethernet probing to the first usage. One more comment below. > Reported-by: Deepak Sikri > Reported-by: Armando Visconti > Signed-off-by: Shiraz Hashim > Signed-off-by: Amit Virdi > --- > include/configs/spear-common.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/configs/spear-common.h > b/include/configs/spear-common.h index 5b6ef72..26642f1 100644 > --- a/include/configs/spear-common.h > +++ b/include/configs/spear-common.h > @@ -35,6 +35,7 @@ > #define CONFIG_DW0_PHY 1 > #define CONFIG_NET_MULTI > #define CONFIG_PHY_RESET_DELAY (10000) /* in usec */ > +#define CONFIG_DW_AUTONEG 1 Please don't add the "1" here. > #endif > > /* USBD driver configuration */ -- Viele Gr??e, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de