Re: [PATCH 0/2] perf: add sort by inclusive time functionality (v2)

From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Arun Sharma <asharma@fb.com>,
	linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Namhyung Kim <namhyung.kim@lge.com>,
	Tom Zanussi <tzanussi@gmail.com>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 0/2] perf: add sort by inclusive time functionality (v2)
Date: Thu, 8 Mar 2012 16:31:34 +0100	[thread overview]
Message-ID: <20120308153130.GC7976@somewhere.redhat.com> (raw)
In-Reply-To: <20120308072901.GC20784@elte.hu>

On Thu, Mar 08, 2012 at 08:29:01AM +0100, Ingo Molnar wrote:
> 
> * Arun Sharma <asharma@fb.com> wrote:
> 
> > This patch series refactors existing code a bit and adds sort by 
> > inclusive time (time spent in the function + callees).
> > 
> > Sample command lines:
> > 
> > # perf record -ag -- sleep 1
> > # perf report -g graph,0.5,callee -n -s inclusive
> 
> So I tried this out with:
> 
>   $ taskset 1 perf record -g git gc
> 
> and got entries above 100% (in the TUI):
> 
>   $ perf report -g graph,0.5,callee -n -s inclusive
> 
>  +  321.11%        5628  [.] 0x392b609269
>  +  142.27%        3774  [.] create_delta
>  +  78.86%        1248  [.] lookup_object
>  +  40.54%        1348  [k] system_call_fastpath
>  [...]
> 
> Is that expected?

I think this happens because of this:

-               hists->stats.total_period += h->period;                                                                                
+               if (!h->inclusive)                                                                                                     
+                       hists->stats.total_period += h->period;

Which I'm not sure why it is needed btw.