From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758127Ab2CIQhq (ORCPT ); Fri, 9 Mar 2012 11:37:46 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:35016 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754557Ab2CIQhp (ORCPT ); Fri, 9 Mar 2012 11:37:45 -0500 Date: Fri, 9 Mar 2012 08:37:39 -0800 From: Greg Kroah-Hartman To: Linus Walleij Cc: Chanho Min , Russell King , Alan Cox , Shreshtha Kumar Sahu , "Kim, Jong-Sung" , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] Clear previous interrupts after fifo is disabled Message-ID: <20120309163739.GA9545@kroah.com> References: <20120308184954.GA1275@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 09, 2012 at 05:34:03PM +0100, Linus Walleij wrote: > On Thu, Mar 8, 2012 at 7:49 PM, Greg Kroah-Hartman > wrote: > > On Mon, Feb 27, 2012 at 06:30:20PM +0900, Chanho Min wrote: > >> This is another workaroud of  'https://lkml.org/lkml/2012/1/17/104' > >> with additional analysis.Bootloader can transfer control to kernel and > >> there are some pending interrupts. In this case, RXFE of the flag > >> register is set by clearing FEN(LCRH) even if rx data remains in the > >> fifo. It seems that the fifo's status is initiailized. Interrupt > >> handler can not get any data from data register because of the below > >> break condtion. > >> > >> pl011_fifo_to_tty > >>  while (max_count--) { > >>    if (status & UART01x_FR_RXFE) > >>       break; > > > > This patch never seemed to be agreed on, so I'm not taking it. > > > > Can someone, if this is still needed, and everyone agrees on how to > > solve it, please send me the needed fix? > > To me it seems Russell's patch solves part of the problem, > and Jong-Sung Kim's patch on top of that solves the entire > problem, but Chanho need to come back and tell whether > this is the case in practice. Ok, then, once it is tested, can someone resend them to me? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] Clear previous interrupts after fifo is disabled Date: Fri, 9 Mar 2012 08:37:39 -0800 Message-ID: <20120309163739.GA9545@kroah.com> References: <20120308184954.GA1275@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-yw0-f46.google.com ([209.85.213.46]:38037 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757524Ab2CIQhp (ORCPT ); Fri, 9 Mar 2012 11:37:45 -0500 Received: by yhmm54 with SMTP id m54so941244yhm.19 for ; Fri, 09 Mar 2012 08:37:45 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Linus Walleij Cc: Chanho Min , Russell King , Alan Cox , Shreshtha Kumar Sahu , "Kim, Jong-Sung" , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org On Fri, Mar 09, 2012 at 05:34:03PM +0100, Linus Walleij wrote: > On Thu, Mar 8, 2012 at 7:49 PM, Greg Kroah-Hartman > wrote: > > On Mon, Feb 27, 2012 at 06:30:20PM +0900, Chanho Min wrote: > >> This is another workaroud of =A0'https://lkml.org/lkml/2012/1/17/1= 04' > >> with additional analysis.Bootloader can transfer control to kernel= and > >> there are some pending interrupts. In this case, RXFE of the flag > >> register is set by clearing FEN(LCRH) even if rx data remains in t= he > >> fifo. It seems that the fifo's status is initiailized. Interrupt > >> handler can not get any data from data register because of the bel= ow > >> break condtion. > >> > >> pl011_fifo_to_tty > >> =A0while (max_count--) { > >> =A0 =A0if (status & UART01x_FR_RXFE) > >> =A0 =A0 =A0 break; > > > > This patch never seemed to be agreed on, so I'm not taking it. > > > > Can someone, if this is still needed, and everyone agrees on how to > > solve it, please send me the needed fix? >=20 > To me it seems Russell's patch solves part of the problem, > and Jong-Sung Kim's patch on top of that solves the entire > problem, but Chanho need to come back and tell whether > this is the case in practice. Ok, then, once it is tested, can someone resend them to me? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html