All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3] net: fec_mxc: allow use with cache enabled
Date: Tue, 13 Mar 2012 10:41:14 -0400	[thread overview]
Message-ID: <201203131041.15454.vapier@gentoo.org> (raw)
In-Reply-To: <1331647471-4440-1-git-send-email-eric.nelson@boundarydevices.com>

On Tuesday 13 March 2012 10:04:31 Eric Nelson wrote:
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> 
> +#if ARCH_DMA_MINALIGN > CONFIG_SYS_CACHELINE_SIZE
> +#define CONFIG_FEC_ALIGN ARCH_DMA_MINALIGN
> +#else
> +#define CONFIG_FEC_ALIGN CONFIG_SYS_CACHELINE_SIZE
> +#endif

i don't think this is something you should be checking.  if this is an actual 
problem (and i don't think it is), it's something we should handle in common 
code.  if you need to dma from memory, then use ARCH_DMA_MINALIGN.

> +#error	"CONFIG_FEC_ALIGN must be multiple of 16!"
> +#error	"PKTALIGN must be multiple of CONFIG_FEC_ALIGN!"

please don't use tabs after #define/#error/etc... just one space
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120313/644a5ecb/attachment.pgp>

  reply	other threads:[~2012-03-13 14:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <http://lists.denx.de/pipermail/u-boot/2012-March/#119442>
2012-03-13 14:04 ` [U-Boot] [PATCH V3] net: fec_mxc: allow use with cache enabled Eric Nelson
2012-03-13 14:41   ` Mike Frysinger [this message]
2012-03-13 18:42     ` Eric Nelson
2012-03-13 20:14       ` Mike Frysinger
2012-03-14  1:43         ` Marek Vasut
2012-03-14  5:12           ` Eric Nelson
2012-03-14  5:41             ` Mike Frysinger
2012-03-14 19:12               ` Eric Nelson
2012-03-14 20:33                 ` Mike Frysinger
2012-03-14 21:04                   ` Eric Nelson
2012-03-14 21:15                     ` Mike Frysinger
2012-03-14  5:45             ` Marek Vasut
2012-03-14  1:42       ` Marek Vasut
2012-03-13 15:48   ` Eric Nelson
2012-03-14  1:44     ` Marek Vasut
2012-03-14  1:46   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203131041.15454.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.