From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: Alex Shi <alex.shi@intel.com>
Cc: gregkh <gregkh@linuxfoundation.org>,
"Sharp, Sarah A" <sarah.a.sharp@intel.com>,
Alan stern <stern@rowland.harvard.edu>,
Felipe Balbi <balbi@ti.com>,
linux-usb <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb/xhci: unify parameter of xhci_msi_irq
Date: Thu, 15 Mar 2012 10:56:08 -0700 [thread overview]
Message-ID: <20120315175608.GA6077@xanatos> (raw)
In-Reply-To: <4F6204B7.5010908@intel.com>
On Thu, Mar 15, 2012 at 11:03:19PM +0800, Alex Shi wrote:
> On 03/15/2012 10:57 PM, gregkh wrote:
>
> > On Thu, Mar 15, 2012 at 12:53:06PM +0800, Alex Shi wrote:
> >>
> >> According to Felipe and Alan's comments the second parameter of irq
> >> handler should be 'void *' not a specific structure pointer.
> >> So change it.
> >>
> >> Signed-off-by: Alex Shi <alex.shi@intel.com>
> >> ---
> >> drivers/usb/host/xhci-ring.c | 2 +-
> >> drivers/usb/host/xhci.c | 4 ++--
> >> drivers/usb/host/xhci.h | 2 +-
> >> 3 files changed, 4 insertions(+), 4 deletions(-)
> >
> > Is this needed in my -next tree now? Or is it something for later?
>
>
> Appreciate if it can be in -next tree. :)
>
> >
> > Any reason you did not put Sarah on the To: line here? She's the one
> > that needs to ack it before I can accept it.
>
>
> Sarah, would you like to give some comments here?
Looks fine. I'll send a pull request to Greg with this patch after I
verify it doesn't generate new warnings.
Sarah Sharp
next prev parent reply other threads:[~2012-03-15 17:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 4:53 [PATCH] usb/xhci: unify parameter of xhci_msi_irq Alex Shi
2012-03-15 9:08 ` Felipe Balbi
2012-03-15 14:57 ` gregkh
2012-03-15 15:03 ` Alex Shi
2012-03-15 17:56 ` Sarah Sharp [this message]
2012-03-17 0:02 ` Alex Shi
2012-05-30 7:46 ` Alex Shi
2012-06-11 7:14 ` Alex Shi
2012-06-11 20:47 ` Sarah Sharp
2012-06-11 21:14 ` gregkh
2012-06-12 0:05 ` Alex Shi
2012-08-13 5:59 ` Alex Shi
2012-08-26 2:01 ` Sarah Sharp
2012-08-26 13:58 ` Alex Shi
2013-05-24 2:54 Alex Shi
2013-05-28 13:39 ` Alex Shi
2013-05-29 13:31 ` Alex Shi
2013-06-05 23:29 ` Sarah Sharp
2013-06-05 23:52 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315175608.GA6077@xanatos \
--to=sarah.a.sharp@linux.intel.com \
--cc=alex.shi@intel.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.