All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: Heiko Schocher <hs@denx.de>
Cc: devicetree-discuss@ozlabs.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 2/4] powerpc, mpc52xx: add a4m072 board support
Date: Mon, 19 Mar 2012 00:38:57 +0100	[thread overview]
Message-ID: <20120319003857.7a64163f@wker> (raw)
In-Reply-To: <1308739150-31527-1-git-send-email-hs@denx.de>

Hi Heiko,

On Wed, 22 Jun 2011 12:39:10 +0200
Heiko Schocher <hs@denx.de> wrote:
...
> diff --git a/arch/powerpc/boot/dts/a4m072.dts b/arch/powerpc/boot/dts/a4m072.dts
> new file mode 100644
> index 0000000..adb6746
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/a4m072.dts
...
> +		cdm@200 {
> +			fsl,ext_48mhz_en = <0x0>;
> +			fsl,fd_enable = <0x01>;
> +			fsl,fd_counters = <0xbbbb>;

When applying this patch I've fixed these properties according to
previously added bindings (fsl,init-*-*), but one question remains:
is fd-counters value really 0xbbbb? Here, the 3rd bit in each nibble
should always be cleared as mentioned in the register description.

...
> +		timer@600 {
> +			compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
> +			reg = <0x600 0x80>;
> +			interrupts = <1 9 0>;

I've removed above three lines as these are already in the dtsi file.

Thanks,
Anatolij

  parent reply	other threads:[~2012-03-18 23:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22  7:55 [PATCH 0/4] powerpc, mpc5200: add support for a4m072 board Heiko Schocher
2011-06-22  7:55 ` [PATCH 1/4] net, phy: am79c874 support Heiko Schocher
2011-07-26  4:55   ` Heiko Schocher
2012-03-18 21:13     ` Anatolij Gustschin
2012-03-18 21:22   ` Anatolij Gustschin
     [not found] ` <1308729311-15375-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2011-06-22  7:55   ` [PATCH 2/4] powerpc, mpc52xx: add a4m072 board support Heiko Schocher
2011-06-22  7:55     ` Heiko Schocher
     [not found]     ` <1308729311-15375-3-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2011-06-22  8:09       ` Wolfram Sang
2011-06-22  8:09         ` Wolfram Sang
2011-06-22  8:13         ` Heiko Schocher
2011-06-22  8:25           ` Wolfram Sang
2011-06-22  8:25             ` Wolfram Sang
2011-06-22 10:39     ` [PATCH v2 " Heiko Schocher
2011-07-26  4:52       ` Heiko Schocher
2011-07-31  4:08       ` Grant Likely
2011-08-01  5:30         ` Heiko Schocher
2012-03-18 23:38       ` Anatolij Gustschin [this message]
2011-07-31  4:05     ` [PATCH " Grant Likely
2011-06-22  7:55 ` [PATCH 3/4] powerpc, mpc5200: update mpc5200_defconfig Heiko Schocher
2011-06-22  7:55 ` [PATCH 4/4] powerpc, mpc5200: add options to mpc5200_defconfig Heiko Schocher
2012-03-18 23:44   ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120319003857.7a64163f@wker \
    --to=agust@denx.de \
    --cc=devicetree-discuss@ozlabs.org \
    --cc=hs@denx.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.