From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] ARM i.MX27: implement clocks using common clock framework
Date: Mon, 19 Mar 2012 16:17:47 +0000 [thread overview]
Message-ID: <201203191617.47225.arnd@arndb.de> (raw)
In-Reply-To: <20120319143608.GZ3852@pengutronix.de>
On Monday 19 March 2012, Sascha Hauer wrote:
> > > +struct clkl {
> > > + struct clk_lookup lookup;
> > > + const char *clkname;
> > > +};
> > > +
> > > +#define clkdev(d, n, c) \
> > > + { \
> > > + .lookup.dev_id = d, \
> > > + .lookup.con_id = n, \
> > > + .clkname = c, \
> > > + },
> > > +
> >
> > They should at least be defined in arch/arm/mach-imx/clk.h to avoid
> > the duplication in every single imx clock driver.
>
> Yes, right. See it as a quick-n-dirty solution...
>
Or maybe just remove the macro. Open-coding seems to take little more space,
and I actually find it more readable:
static struct clkl lookups[] = {
{ { .dev_id = "imx21-uart.0", .con_id = "ipg" }, "uart1_ipg_gate" },
{ { .dev_id = "imx21-uart.0", .con_id = "per" }, "per1_gate" },
{ { .dev_id = "imx21-uart.1", .con_id = "ipg" }, "uart2_ipg_gate" },
{ ... },
};
Arnd
next prev parent reply other threads:[~2012-03-19 16:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 13:35 i.MX: Convert v4/v5 based SoCs to common clock framework Sascha Hauer
2012-03-19 13:35 ` [PATCH 1/8] clk: add a fixed factor clock Sascha Hauer
2012-03-23 7:37 ` Philipp Zabel
2012-03-23 8:40 ` Sascha Hauer
2012-03-23 7:41 ` Philipp Zabel
2012-03-23 8:42 ` Sascha Hauer
2012-03-19 13:36 ` [PATCH 2/8] ARM i.MX: prepare for common clock framework Sascha Hauer
2012-03-19 13:36 ` [PATCH 3/8] ARM i.MX timer: request correct clock Sascha Hauer
2012-03-19 13:36 ` [PATCH 4/8] ARM i.MX: Add common clock support for pllv1 Sascha Hauer
2012-03-19 13:36 ` [PATCH 5/8] ARM i.MX1: implement clocks using common clock framework Sascha Hauer
2012-03-19 13:36 ` [PATCH 6/8] ARM i.MX21: " Sascha Hauer
2012-03-19 13:36 ` [PATCH 7/8] ARM i.MX25: " Sascha Hauer
2012-03-19 13:36 ` [PATCH 8/8] ARM i.MX27: " Sascha Hauer
2012-03-19 14:23 ` Shawn Guo
2012-03-19 14:36 ` Sascha Hauer
2012-03-19 16:17 ` Arnd Bergmann [this message]
2012-03-19 14:44 ` i.MX: Convert v4/v5 based SoCs to " Rob Herring
2012-03-20 23:27 ` Turquette, Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203191617.47225.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.