From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 02/25] drm/i915: add debug message when EDID
 fetch fails
Date: Wed, 21 Mar 2012 13:53:12 -0700
Message-ID: <20120321135312.66e04ab4@jbarnes-desktop>
References: <1332359326-15051-1-git-send-email-jbarnes@virtuousgeek.org>
	<1332359326-15051-3-git-send-email-jbarnes@virtuousgeek.org>
	<CAC7Lmnu1r7LsR5q_Oy35+JRpHY8v6Sdqak2BOmRvzQ1oDkartQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1076168230=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com
	[67.222.54.6])
	by gabe.freedesktop.org (Postfix) with SMTP id 912469EF59
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 21 Mar 2012 13:53:16 -0700 (PDT)
In-Reply-To: <CAC7Lmnu1r7LsR5q_Oy35+JRpHY8v6Sdqak2BOmRvzQ1oDkartQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eugeni Dodonov <eugeni@dodonov.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1076168230==
Content-Type: multipart/signed; micalg=PGP-SHA1;
 boundary="Sig_/sSpg.YUS+EXpJ1VWcfB.mXz"; protocol="application/pgp-signature"

--Sig_/sSpg.YUS+EXpJ1VWcfB.mXz
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Wed, 21 Mar 2012 17:44:12 -0300
Eugeni Dodonov <eugeni@dodonov.net> wrote:

> On Wed, Mar 21, 2012 at 16:48, Jesse Barnes <jbarnes@virtuousgeek.org>wro=
te:
>=20
> > +       } else {
>=20
> +               DRM_DEBUG_KMS("failed to fetch edid\n");
> >        }
> >
>=20
>=20
> Wouldn't it be prettier if we also add some:
>    ...
>    err =3D -ENXIO;
>=20
> or similar error in that block, to let the caller know that we failed as
> well?
>=20
>=20
> >        return ret;
> >
>=20

Maybe but I think most callers just check for the EDID later anyway.

Really this patch can be dropped, but I was wondering exactly where the
GPIO side of things was failing and added some debug output...

--=20
Jesse Barnes, Intel Open Source Technology Center

--Sig_/sSpg.YUS+EXpJ1VWcfB.mXz
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJPaj+5AAoJEIEoDkX4Qk9haQsP/0WoOYjr0Z4IIdDRnzK2SEnf
Ji8Wck4+1CU9uS5LRZ/ngxNp3SSgm0foYYilDNjRdtT/ByTfzR7hlL5RMbLAspLg
FI1ZurmtQ42i9m/TCKlll90n3kC8iohYtKsqPznAD+MgUP+56cH+rBB3IwM/momD
AkH7N/WuX65FeqeeYZd9COqCKycvebOrLWFptaHmNG0Wl+rPcWgZzSUuVhr0mtq6
glsYd+uBO/TxQwn6MJ+1d0pT1EK9fFw7nZRnu41M/Dg0cqAOM4eKYCaJy9N4g6iG
kU5OxcGkaOqvSHOXq8fOt8m04lAi1tl1ocOyB7EZI1LKKt1lquXg9ZDeDwCV60mY
0foBAXXR4IYHAypo0ZEifbrSvbx6uLWMiyrrwHd+1Q9sR1KrdJiOKT8f4PE32mFl
OGIz5QmCPqj3L0E9k7+nY49cl2GnUAurIKfYGnvmb07EbYcJZ28Hcs9sLxR6xdE9
Ym/2bBP3LkuxBO8p4FBZX7A+NSJVnPQCsCvUQWhiwXjbC3hKXE1fIBtrkT070iun
fKHWU+ayfm2/ZUDDjpMpJ/H31b77nIXMlN6BlXQTjTXhm0OpUlwBlNE99tEW39tU
hjXaEgiloEwKvqUYddLoyp3X2xVlxQjykjtbyLBevV5MKq/5ZyUihSHwIhX5+lK5
488CA0v7Ejzl5V2oSyR0
=k990
-----END PGP SIGNATURE-----

--Sig_/sSpg.YUS+EXpJ1VWcfB.mXz--

--===============1076168230==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1076168230==--