From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 16/25] drm/i915: add ValleyView specific force wake get/put functions Date: Wed, 21 Mar 2012 14:32:20 -0700 Message-ID: <20120321143220.71b94d63@jbarnes-desktop> References: <1332359326-15051-1-git-send-email-jbarnes@virtuousgeek.org> <1332359326-15051-17-git-send-email-jbarnes@virtuousgeek.org> <20120321211125.GH9913@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0673728378==" Return-path: Received: from oproxy5-pub.bluehost.com (oproxy5-pub.bluehost.com [67.222.38.55]) by gabe.freedesktop.org (Postfix) with SMTP id 21ABD9E761 for ; Wed, 21 Mar 2012 14:32:23 -0700 (PDT) In-Reply-To: <20120321211125.GH9913@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0673728378== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/d0CSLssFo8nEZ5QClwtDIt."; protocol="application/pgp-signature" --Sig_/d0CSLssFo8nEZ5QClwtDIt. Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 21 Mar 2012 22:11:25 +0100 Daniel Vetter wrote: > On Wed, Mar 21, 2012 at 12:48:37PM -0700, Jesse Barnes wrote: > > ValleyView handles force wake differently than previous chipsets, so add > > a couple of new functions for it. > >=20 > > But it's also untested, so no need to call these untested functions yet. > >=20 > > Signed-off-by: Jesse Barnes >=20 > So we have forcewake but we don't need forcewak?! Can you explain how this > works for dense me a bit? We need force wake, just not for any parts I've tested yet (the early ones had the Punit disabled). This code adheres to the spec, but I'll need a part with the Punit enabled in order to test & verify. Until then we can leave it disabled. --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/d0CSLssFo8nEZ5QClwtDIt. Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPakjkAAoJEIEoDkX4Qk9hPjgP/iNpXxXXXLseLlgRkWYBkKwG 47cZSOLgyjF5bZvgSkWFCanDCgeP7rB4oPEyt/KfaWd6eInE1Dj/Y7SO86J0VD5o yrYtSjlOCmWmTXXWVkcg3kZmAniUc9PYIPawvl4mW1WCbl7pTe+Vc0bRw0C354jZ 2mUtskyPOQDQ4ix/vXRQzg03tnLJ7HQD+COIcwRFgpQ3j7zLb8d3wAPIzwmgKI2r KRoTeT7jLmKRpzx4mCzwvzy9H2OzbCofZuClecN7f2Dbc1r6BwnDKfYrscw+Ygw5 HxAlBjgmzxT+nbWgu9GAQlaXoVxcbdvu7kZap7Be8Lm+L6tmwA8RlC1zPLRSAEu4 nB46btKx6ThpicfQimngZoBFHqvMobCKUO2k7+nwQ06WD9JDp0WHgfhlNMg7abTK wK7Z8+K2UsOVnJYvjNIqbG6n7pWNRp0B0EOhPw08Jt6LE6BFbSL+ZGpvydC2uefr 1Mt/fSPB6WDR1wf0IoErylEC6ACc0vu1nEugE0mJJVjNVay/zvIbSwc1SnaZb+Q8 DQAFVhC1QZUPZ+3gSiZjDHs8NXHg3yAa3Tdx6mv1ID/MoYW911/086y6zXchOLLS wc7hDmnhUQ9i4T6Ov6o13IImg1/zyD1tR/dp9z4+ILkkcW6gBO5W1S/ZBXN0HUMc FAtjSbdcj5m7gslFG3rA =1kt/ -----END PGP SIGNATURE----- --Sig_/d0CSLssFo8nEZ5QClwtDIt.-- --===============0673728378== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0673728378==--