From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 02/25] drm/i915: add debug message when EDID
 fetch fails
Date: Wed, 21 Mar 2012 18:02:21 -0700
Message-ID: <20120321180221.1dc6d8a2@bwidawsk.net>
References: <1332359326-15051-1-git-send-email-jbarnes@virtuousgeek.org>
	<1332359326-15051-3-git-send-email-jbarnes@virtuousgeek.org>
	<CAC7Lmnu1r7LsR5q_Oy35+JRpHY8v6Sdqak2BOmRvzQ1oDkartQ@mail.gmail.com>
	<20120321135312.66e04ab4@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id A23D19E9D1
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 21 Mar 2012 18:02:31 -0700 (PDT)
In-Reply-To: <20120321135312.66e04ab4@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 21 Mar 2012 13:53:12 -0700
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> On Wed, 21 Mar 2012 17:44:12 -0300
> Eugeni Dodonov <eugeni@dodonov.net> wrote:
> 
> > On Wed, Mar 21, 2012 at 16:48, Jesse Barnes
> > <jbarnes@virtuousgeek.org>wrote:
> > 
> > > +       } else {
> > 
> > +               DRM_DEBUG_KMS("failed to fetch edid\n");
> > >        }
> > >
> > 
> > 
> > Wouldn't it be prettier if we also add some:
> >    ...
> >    err = -ENXIO;
> > 
> > or similar error in that block, to let the caller know that we
> > failed as well?
> > 
> > 
> > >        return ret;
> > >
> > 
> 
> Maybe but I think most callers just check for the EDID later anyway.
> 
> Really this patch can be dropped, but I was wondering exactly where
> the GPIO side of things was failing and added some debug output...
> 

I guess it's not exactly an error if no modes were gotten, so
returning 0 seems right (and initially confusing to me as well). Can you
add some information about the connector and/or adapter. Otherwise I
don't think this is very helpful.