From: "Ted Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
linux-ext4@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ext2: Don't export ext2_mask_flags() to user space
Date: Wed, 21 Mar 2012 19:16:51 -0400 [thread overview]
Message-ID: <20120321231651.GC32041@thunk.org> (raw)
In-Reply-To: <20120321222357.GB24330@quack.suse.cz>
On Wed, Mar 21, 2012 at 11:23:57PM +0100, Jan Kara wrote:
> Frankly, anybody seriously wanting to do anything with ext[2-4]
> filesystems should use header files as provided by libext2fs. So I wonder
> if just unexporting the whole file wouldn't be the best solution going
> forward. Ted, do you have opinion?
Agreed, it's been almost 8 years since e2fsprogs used the
include/linux/ext2_fs.h (the last version that needed it was e2fsprogs
1.35, released February 28, 2004).
There shouldn't be *anyone* using any of the ext2/3/4 kernel header
files. The only program that might be cheating and using kernel
header files is ext3grep, as the author wasn't willing to fix his
applications to use libext2fs. (As a result, it doesn't work on ext4
file systems, where as properly coded programs that do use libext2fs
often work just fine on ext4, such as e2tools, which hasn't been
modified for something like eight years but which works on ext4 just
fine.)
So yeah, I'd just unexport ext2_fs.h, and probably ext3_fs.h as well.
- Ted
next prev parent reply other threads:[~2012-03-21 23:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 21:50 [PATCH] ext2: Don't export ext2_mask_flags() to user space Thierry Reding
2012-03-21 22:23 ` Jan Kara
2012-03-21 23:16 ` Ted Ts'o [this message]
2012-03-22 5:53 ` Thierry Reding
2012-03-22 6:00 ` Artem Bityutskiy
2012-03-22 16:28 ` Ted Ts'o
2012-03-22 16:47 ` Thierry Reding
2012-03-22 18:31 ` Ted Ts'o
2012-03-23 9:27 ` [PATCH] ext2: No longer export ext2_fs.h " Thierry Reding
2012-03-23 9:27 ` Thierry Reding
2012-03-23 13:13 ` Ted Ts'o
2012-03-23 17:55 ` Al Viro
2012-03-24 21:51 ` Ted Ts'o
2012-03-24 22:16 ` H. Peter Anvin
2012-03-25 1:16 ` Ted Ts'o
2012-03-22 17:31 ` [PATCH] ext2: Don't export ext2_mask_flags() " Al Viro
2012-03-23 0:25 ` Andreas Dilger
2012-03-24 6:51 ` Mike Frysinger
2012-03-24 6:50 ` Mike Frysinger
2012-03-24 6:50 ` Mike Frysinger
2012-03-24 8:37 ` Al Viro
2012-03-24 17:59 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321231651.GC32041@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.