From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755740Ab2CVAo0 (ORCPT ); Wed, 21 Mar 2012 20:44:26 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:39773 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755443Ab2CVAoY (ORCPT ); Wed, 21 Mar 2012 20:44:24 -0400 Date: Thu, 22 Mar 2012 00:42:58 +0000 From: Russell King - ARM Linux To: Saravana Kannan Cc: Tony Lindgren , Mark Brown , Paul Walmsley , Nicolas Pitre , Sascha Hauer , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Amit Kucheria , linaro-dev@lists.linaro.org, Linus Walleij , Grant Likely , Jeremy Kerr , Mike Turquette , Mike Turquette , Magnus Damm , Deepak Saxena , patches@linaro.org, Rob Herring , Thomas Gleixner , Richard Zhao , Shawn Guo , Linus Walleij , Stephen Boyd , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/3] Documentation: common clk API Message-ID: <20120322004258.GG16389@n2100.arm.linux.org.uk> References: <4F6A2042.9030302@codeaurora.org> <20120321190741.GL3226@opensource.wolfsonmicro.com> <20120321193304.GO9859@atomide.com> <4F6A2EF5.3010008@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F6A2EF5.3010008@codeaurora.org> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 21, 2012 at 12:41:41PM -0700, Saravana Kannan wrote: > The meaning of clk_enable/disable has been changed and they won't work > without calling clk_prepare/unprepare. So, these are definitely new > APIs. If it weren't new APIs, then none of the general drivers would > need to change. Yes and no. I disagree that the meaning of clk_enable/disable() has changed. It hasn't. What has changed is the preconditions for calling those functions, and necessarily so in the interest of being able to unify the different implementations. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v7 1/3] Documentation: common clk API Date: Thu, 22 Mar 2012 00:42:58 +0000 Message-ID: <20120322004258.GG16389@n2100.arm.linux.org.uk> References: <4F6A2042.9030302@codeaurora.org> <20120321190741.GL3226@opensource.wolfsonmicro.com> <20120321193304.GO9859@atomide.com> <4F6A2EF5.3010008@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4F6A2EF5.3010008-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linaro-dev-bounces-cunTk1MwBs8s++Sfvej+rw@public.gmane.org Errors-To: linaro-dev-bounces-cunTk1MwBs8s++Sfvej+rw@public.gmane.org To: Saravana Kannan Cc: Nicolas Pitre , linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, Tony Lindgren , Jeremy Kerr , Magnus Damm , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Arnd Bergmann , patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Sascha Hauer , Rob Herring , Thomas Gleixner , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Paul Walmsley , Linus Walleij , Mark Brown , Stephen Boyd , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org On Wed, Mar 21, 2012 at 12:41:41PM -0700, Saravana Kannan wrote: > The meaning of clk_enable/disable has been changed and they won't work > without calling clk_prepare/unprepare. So, these are definitely new > APIs. If it weren't new APIs, then none of the general drivers would > need to change. Yes and no. I disagree that the meaning of clk_enable/disable() has changed. It hasn't. What has changed is the preconditions for calling those functions, and necessarily so in the interest of being able to unify the different implementations. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Thu, 22 Mar 2012 00:42:58 +0000 Subject: [PATCH v7 1/3] Documentation: common clk API In-Reply-To: <4F6A2EF5.3010008@codeaurora.org> References: <4F6A2042.9030302@codeaurora.org> <20120321190741.GL3226@opensource.wolfsonmicro.com> <20120321193304.GO9859@atomide.com> <4F6A2EF5.3010008@codeaurora.org> Message-ID: <20120322004258.GG16389@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Mar 21, 2012 at 12:41:41PM -0700, Saravana Kannan wrote: > The meaning of clk_enable/disable has been changed and they won't work > without calling clk_prepare/unprepare. So, these are definitely new > APIs. If it weren't new APIs, then none of the general drivers would > need to change. Yes and no. I disagree that the meaning of clk_enable/disable() has changed. It hasn't. What has changed is the preconditions for calling those functions, and necessarily so in the interest of being able to unify the different implementations.