All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] e2fsprogs tests: fix f_bad_disconnected_inode e2fsck output
Date: Thu, 22 Mar 2012 20:18:49 -0400	[thread overview]
Message-ID: <20120323001849.GA5832@thunk.org> (raw)
In-Reply-To: <1332333293-25028-2-git-send-email-lczerner@redhat.com>

Thanks, I've applied these two patches as a single commit.  (In
general the regression tests should always pass after each commit, so
that git bisects work correctly.)

					- Ted

On Wed, Mar 21, 2012 at 01:34:53PM +0100, Lukas Czerner wrote:
> Since we removed EOFBLOCKS_FL flag handling, we have to fix the
> f_bad_disconnected_inode test so that e2fsck output correspond with the
> new version of the code where we do not check for the EOFBLOCKS_FL flag
> at all.
> 
> Simply remove EOFBLOCKS_FL flag warnings from expect.1 e2fsck output.
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
>  tests/f_bad_disconnected_inode/expect.1 |    9 ---------
>  1 files changed, 0 insertions(+), 9 deletions(-)
> 
> diff --git a/tests/f_bad_disconnected_inode/expect.1 b/tests/f_bad_disconnected_inode/expect.1
> index d3920e3..11862f6 100644
> --- a/tests/f_bad_disconnected_inode/expect.1
> +++ b/tests/f_bad_disconnected_inode/expect.1
> @@ -2,21 +2,12 @@ Pass 1: Checking inodes, blocks, and sizes
>  Inode 1 has EXTENTS_FL flag set on filesystem without extents support.
>  Clear? yes
>  
> -Inode 9 should not have EOFBLOCKS_FL set (size 0, lblk -1)
> -Clear? yes
> -
> -Inode 10 should not have EOFBLOCKS_FL set (size 0, lblk -1)
> -Clear? yes
> -
>  Inode 15 has EXTENTS_FL flag set on filesystem without extents support.
>  Clear? yes
>  
>  Inode 16 has EXTENTS_FL flag set on filesystem without extents support.
>  Clear? yes
>  
> -Inode 13 should not have EOFBLOCKS_FL set (size 0, lblk -1)
> -Clear? yes
> -
>  Pass 2: Checking directory structure
>  Pass 3: Checking directory connectivity
>  /lost+found not found.  Create? yes
> -- 
> 1.7.4.4
> 

  reply	other threads:[~2012-03-23  3:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-21 12:34 [PATCH 1/2] e2fsck: remove EXT4_EOFBLOCKS_FL flag handling Lukas Czerner
2012-03-21 12:34 ` [PATCH 2/2] e2fsprogs tests: fix f_bad_disconnected_inode e2fsck output Lukas Czerner
2012-03-23  0:18   ` Ted Ts'o [this message]
2012-03-23  8:03     ` Lukas Czerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120323001849.GA5832@thunk.org \
    --to=tytso@mit.edu \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.