From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBSzj-0001pq-He for qemu-devel@nongnu.org; Sat, 24 Mar 2012 11:35:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SBSzh-0007Ve-Vi for qemu-devel@nongnu.org; Sat, 24 Mar 2012 11:35:07 -0400 Received: from verein.lst.de ([213.95.11.211]:52369 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBSzh-0007Tx-Pi for qemu-devel@nongnu.org; Sat, 24 Mar 2012 11:35:05 -0400 Date: Sat, 24 Mar 2012 16:35:04 +0100 From: Christoph Hellwig Message-ID: <20120324153504.GE13014@lst.de> References: <1331226917-6658-1-git-send-email-pbonzini@redhat.com> <1331226917-6658-14-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331226917-6658-14-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH 13/17] block: fallback from discard to writes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Thu, Mar 08, 2012 at 06:15:13PM +0100, Paolo Bonzini wrote: > Allow discard to fail, and fall back to the write operation. This > is needed because there's no simple way to probe for availability > of FALLOC_FL_PUNCH_HOLE. So you switch on advertising TRIM support in the patch before, and then fall back to a very suboptimal implementation here? This will make Windows 7 users very unhappy.