From: David Miller <davem@davemloft.net>
To: dwmw2@infradead.org
Cc: netdev@vger.kernel.org
Subject: Re: [STRAW MAN PATCH] sch_teql doesn't load-balance ppp(oatm) slaves
Date: Sun, 25 Mar 2012 17:36:35 -0400 (EDT) [thread overview]
Message-ID: <20120325.173635.1909319488008466320.davem@davemloft.net> (raw)
In-Reply-To: <1332672230.32446.160.camel@shinybook.infradead.org>
From: David Woodhouse <dwmw2@infradead.org>
Date: Sun, 25 Mar 2012 11:43:50 +0100
> It's a bad idea to have huge hidden queues (a whole wmem_default worth
> of packets are in a hidden queue between ppp_generic and the ATM device,
> ffs!) anyway, so perhaps if we just fix *that* within PPP, it should
> work a bit better with TEQL?
Yes, the ATM devices deep transmit queue is quite undesirable.
But I actually don't see how the problem arises yet, I need more
details.
PPP itself will always stop the queue, and return NETDEV_TX_OK on a
transmit attempt. It may wake the queue back up before returning if
the downstream device (such as pppoatm) accepted the packet.
But in either case NETDEV_TX_OK is returned and this is what the teql
master transmit sees, and this takes the code path which advances the
slave pointer to the next device.
Therefore the next teql master transmit should try the next device in
the slave list, not the PPP device used in the previous call.
next prev parent reply other threads:[~2012-03-25 21:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 21:03 [STRAW MAN PATCH] sch_teql doesn't load-balance ppp(oatm) slaves David Woodhouse
2012-03-23 3:03 ` David Miller
2012-03-25 10:43 ` David Woodhouse
2012-03-25 21:36 ` David Miller [this message]
2012-03-26 8:32 ` David Woodhouse
2012-03-26 9:45 ` David Woodhouse
2012-03-26 10:03 ` [PATCH] ppp: Don't stop and restart queue on every TX packet David Woodhouse
2012-04-03 21:29 ` David Miller
2012-04-08 19:58 ` David Woodhouse
2012-04-08 20:01 ` ppp: Fix race condition with queue start/stop David Woodhouse
2012-04-13 17:07 ` David Miller
2012-03-27 19:10 ` [STRAW MAN PATCH] sch_teql doesn't load-balance ppp(oatm) slaves David Woodhouse
2012-03-27 19:55 ` Eric Dumazet
2012-03-27 20:35 ` David Woodhouse
2012-04-08 19:53 ` [PATCH] pppoatm: Fix excessive queue bloat David Woodhouse
2012-04-10 14:26 ` chas williams - CONTRACTOR
2012-04-10 20:28 ` David Woodhouse
2012-04-13 17:04 ` David Miller
2012-04-13 17:27 ` David Miller
2012-04-13 17:05 ` David Miller
2012-04-08 19:55 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120325.173635.1909319488008466320.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.