From: David Miller <davem@davemloft.net>
To: david.ward@ll.mit.edu
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net/garp: avoid infinite loop if attribute already exists
Date: Mon, 26 Mar 2012 17:44:32 -0400 (EDT) [thread overview]
Message-ID: <20120326.174432.594293356850568957.davem@davemloft.net> (raw)
In-Reply-To: <1332715437-16278-1-git-send-email-david.ward@ll.mit.edu>
From: David Ward <david.ward@ll.mit.edu>
Date: Sun, 25 Mar 2012 18:43:56 -0400
> @@ -353,9 +361,9 @@ int garp_request_join(const struct net_device *dev,
>
> spin_lock_bh(&app->lock);
> attr = garp_attr_create(app, data, len, type);
> - if (!attr) {
> + if (IS_ERR(attr)) {
> spin_unlock_bh(&app->lock);
> - return -ENOMEM;
> + return ERR_PTR(attr);
You cannot tell me that this ERR_PTR() thing didn't emit a very loud
warning from the compiler. You want PTR_ERR() instead.
Please don't be so careless, if I can predict compiler warnings just
by reading your patches you are so doing it wrong.
prev parent reply other threads:[~2012-03-26 21:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-25 22:43 [PATCH] net/garp: avoid infinite loop if attribute already exists David Ward
2012-03-25 22:43 ` [PATCH] net/vlan: withdraw VLAN ID attribute from GVRP on VLAN device stop David Ward
2012-03-26 11:29 ` Jorge Boncompte [DTI2]
2012-03-26 13:38 ` Ward, David - 0663 - MITLL
2012-03-26 15:14 ` Jorge Boncompte [DTI2]
2012-03-26 15:50 ` Ward, David - 0663 - MITLL
2012-03-26 21:42 ` David Miller
2012-03-27 1:35 ` Ward, David - 0663 - MITLL
2012-03-26 11:23 ` [PATCH] net/garp: avoid infinite loop if attribute already exists Jorge Boncompte [DTI2]
2012-03-26 14:11 ` Ward, David - 0663 - MITLL
2012-03-26 15:26 ` Jorge Boncompte [DTI2]
2012-03-26 16:07 ` Ward, David - 0663 - MITLL
2012-03-27 19:01 ` [PATCH v2] " David Ward
2012-03-28 11:28 ` Jorge Boncompte [DTI2]
2012-03-28 13:28 ` Ward, David - 0663 - MITLL
2012-03-28 20:45 ` David Miller
2012-03-26 21:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326.174432.594293356850568957.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.ward@ll.mit.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.