From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: console class in kvm Date: Mon, 26 Mar 2012 13:19:42 +0200 Message-ID: <20120326111942.GA15207@redhat.com> References: <20120326094824.GA14504@redhat.com> <4F70428E.4070707@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Amit Shah , yan@daynix.com, qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:4663 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757372Ab2CZLTa (ORCPT ); Mon, 26 Mar 2012 07:19:30 -0400 Content-Disposition: inline In-Reply-To: <4F70428E.4070707@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Mar 26, 2012 at 12:18:54PM +0200, Avi Kivity wrote: > On 03/26/2012 11:48 AM, Michael S. Tsirkin wrote: > > kvm used to carry this commit: > > Used to? Which commit reverts this? A merge from qemu.git I would guess. git log does not seem to show the culprit, I don't know how to find it. > > commit 4667e6ec0df770867095d8093562d93c94d96ca2 > > Author: Avi Kivity > > Date: Thu Feb 12 11:43:17 2009 +0200 > > > > Change virtio-console to PCI_CLASS_OTHERS > > > > As a PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP > > (possibly Windows disables acceleration since it fails to find a driver). > > > > Signed-off-by: Avi Kivity > > > > This seems to have been dropped. Is the issue gone? > > Could relevant parties speak up please? > > Do we want to merge this commit into qemu.git? > > It's an impossible compatibility problem now. I have this sinking > feeling that we need to create yet another driver property. That's easy, we have a class property for this already. > -- > error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SC7xY-0000fn-OJ for qemu-devel@nongnu.org; Mon, 26 Mar 2012 07:19:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SC7xS-0006Ss-H3 for qemu-devel@nongnu.org; Mon, 26 Mar 2012 07:19:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SC7xS-0006Sg-94 for qemu-devel@nongnu.org; Mon, 26 Mar 2012 07:19:30 -0400 Date: Mon, 26 Mar 2012 13:19:42 +0200 From: "Michael S. Tsirkin" Message-ID: <20120326111942.GA15207@redhat.com> References: <20120326094824.GA14504@redhat.com> <4F70428E.4070707@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F70428E.4070707@redhat.com> Subject: Re: [Qemu-devel] console class in kvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Amit Shah , yan@daynix.com, qemu-devel@nongnu.org, kvm@vger.kernel.org On Mon, Mar 26, 2012 at 12:18:54PM +0200, Avi Kivity wrote: > On 03/26/2012 11:48 AM, Michael S. Tsirkin wrote: > > kvm used to carry this commit: > > Used to? Which commit reverts this? A merge from qemu.git I would guess. git log does not seem to show the culprit, I don't know how to find it. > > commit 4667e6ec0df770867095d8093562d93c94d96ca2 > > Author: Avi Kivity > > Date: Thu Feb 12 11:43:17 2009 +0200 > > > > Change virtio-console to PCI_CLASS_OTHERS > > > > As a PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP > > (possibly Windows disables acceleration since it fails to find a driver). > > > > Signed-off-by: Avi Kivity > > > > This seems to have been dropped. Is the issue gone? > > Could relevant parties speak up please? > > Do we want to merge this commit into qemu.git? > > It's an impossible compatibility problem now. I have this sinking > feeling that we need to create yet another driver property. That's easy, we have a class property for this already. > -- > error compiling committee.c: too many arguments to function