From: Stefan Roese <sr@denx.de>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: akpm@linux-foundation.org, devicetree-discuss@lists.ozlabs.org,
rajeev-dlh.kumar@st.com, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com, a.zummo@towertech.it,
spear-devel@list.st.com, viresh.linux@gmail.com,
Rob Herring <robherring2@gmail.com>
Subject: Re: [PATCH] rtc/spear: Add Device Tree probing capability
Date: Mon, 26 Mar 2012 13:32:01 +0200 [thread overview]
Message-ID: <201203261332.02073.sr@denx.de> (raw)
In-Reply-To: <8747a4b3bdcfb7b3384c14ca909228e1164d0fc5.1332755275.git.viresh.kumar@st.com>
On Monday 26 March 2012 11:54:22 Viresh Kumar wrote:
> SPEAr platforms now support DT and so must convert all drivers support DT.
> This patch adds DT probing support for rtc and updates its documentation
> too.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
> ---
> Documentation/devicetree/bindings/rtc/spear-rtc.txt | 18
> ++++++++++++++++++ drivers/rtc/rtc-spear.c |
> 10 ++++++++++ 2 files changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/spear-rtc.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/spear-rtc.txt
> b/Documentation/devicetree/bindings/rtc/spear-rtc.txt new file mode 100644
> index 0000000..928410f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/spear-rtc.txt
> @@ -0,0 +1,18 @@
> +* SPEAr RTC
> +
> +Required properties:
> +- compatible : "st,spear-rtc"
> +- reg : Address range of the rtc registers
> +- interrupt-parent: Should be the phandle for the interrupt controller
> + that services interrupts for this device
> +- interrupt: Should contain the rtc interrupt number
> +
> +Example:
> +
> + rtc@fc000000 {
> + compatible = "st,spear-rtc";
With Rob's comments in mind, wouldn't it be better to use a more specific
compatible property? Should we stick with "st,spear600-rtc"? Or use "st-
spear300-rtc" as "oldest" SoC variant?
Thanks,
Stefan
next prev parent reply other threads:[~2012-03-26 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 9:54 [PATCH] rtc/spear: Add Device Tree probing capability Viresh Kumar
2012-03-26 9:54 ` Viresh Kumar
2012-03-26 11:32 ` Stefan Roese [this message]
2012-03-26 11:39 ` Viresh Kumar
2012-03-26 11:39 ` Viresh Kumar
2012-03-26 12:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203261332.02073.sr@denx.de \
--to=sr@denx.de \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajeev-dlh.kumar@st.com \
--cc=robherring2@gmail.com \
--cc=rtc-linux@googlegroups.com \
--cc=spear-devel@list.st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.