From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCEx1-0005HL-10 for qemu-devel@nongnu.org; Mon, 26 Mar 2012 14:47:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCEwu-0003li-H2 for qemu-devel@nongnu.org; Mon, 26 Mar 2012 14:47:30 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:38856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCEwu-0003l7-AF for qemu-devel@nongnu.org; Mon, 26 Mar 2012 14:47:24 -0400 Received: by yenr5 with SMTP id r5so5042535yen.4 for ; Mon, 26 Mar 2012 11:47:22 -0700 (PDT) Sender: fluxion Date: Mon, 26 Mar 2012 13:47:18 -0500 From: Michael Roth Message-ID: <20120326184718.GA12126@illuin> References: <0ccd5fa1764f254dbde6851c0d2139e9198a25e2.1332256180.git.mprivozn@redhat.com> <20120320161046.GA29058@illuin> <4F709AE5.10409@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4F709AE5.10409@suse.de> Subject: Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Michal Privoznik , qemu-devel@nongnu.org, Stefan Hajnoczi On Mon, Mar 26, 2012 at 06:35:49PM +0200, Andreas Färber wrote: > Am 20.03.2012 17:10, schrieb Michael Roth: > > On Tue, Mar 20, 2012 at 04:09:53PM +0100, Michal Privoznik wrote: > >> Currently, the implementation of that command is full of > >> Linux specific code. Before any brave man will step into > >> and port it to other OSes, make this function Linux only. > >> > >> Signed-off-by: Michal Privoznik > > > > Which aspect is linux-specific? getifaddrs() and getnameinfo() seem to > > be available on BSD and OpenSolaris, and we're already stubbed for w32. > > Are you seeing breakage? > > The two OpenBSD buildbots were reporting breakages: > > http://buildbot.b1-systems.de/qemu/buildslaves/brad_openbsd_current > http://buildbot.b1-systems.de/qemu/buildslaves/kraxel_openbsd49 > > Unfortunately they rarely nag the people to blame ;) and the reports on > qemu-devel are admittedly a bit brief. > > Maybe it might make sense to let the buildbots build your qemu-ga > staging branch as well, Michael? That could catch this in advance. That would great! Is there any process in place for having a repo added? I've been staging directly to pull branches, but started a single staging branch at: git://github.com/mdroth/qemu.git qga > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >