From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 27 Mar 2012 09:05:57 +0200
Subject: [U-Boot] [PATCH 18/25] SPEAr: Correct the definition of
	CONFIG_SYS_MONITOR_BASE
In-Reply-To: <4F71605A.1070907@st.com>
References: <1331121854-20494-1-git-send-email-amit.virdi@st.com>
	<201203071531.06350.sr@denx.de> <4F71605A.1070907@st.com>
Message-ID: <201203270905.57726.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Amit,

On Tuesday 27 March 2012 08:38:18 Amit Virdi wrote:
> >>   #define CONFIG_ENV_SIZE				0x02000
> >> 
> >> +#define CONFIG_SYS_MONITOR_BASE			CONFIG_SYS_TEXT_BASE
> >> +#define CONFIG_MONITOR_IS_IN_RAM		1
> > 
> > Why is CONFIG_MONITOR_IS_IN_RAM defined? And if really needed, please
> > without the 1.
> 
> CONFIG_MONITOR_IS_IN_RAM is defined with the understanding that since,
> u-boot is loaded by the BootROM (embedded in eROM) to RAM, so the
> monitor is present in RAM. Please confirm if this understanding is correct.

Hmmm, seems to be used on some Coldfire and Blackfin platforms. Its not needed 
for your platform. Please remove it.

Thanks,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de