All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: "João Paulo Rechi Vita" <jprvita@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org, dh.herrmann@googlemail.com,
	chen.ganir@ti.com
Subject: Re: [RFC 2/8] HoG: register ATTIO callbacks
Date: Wed, 28 Mar 2012 11:26:44 +0300	[thread overview]
Message-ID: <20120328082641.GA21905@aemeltch-MOBL1> (raw)
In-Reply-To: <1332887487-13601-3-git-send-email-jprvita@openbossa.org>

Hi João,

Minor comments:

On Tue, Mar 27, 2012 at 07:31:21PM -0300, João Paulo Rechi Vita wrote:
...
> +static struct hog_device *hog_device_new(struct btd_device *device,
> +							const char *path)
> +{
...
> +
> +	hogdev->attioid = btd_device_add_attio_callback(device,
> +							attio_connected_cb,
> +							attio_disconnected_cb,
> +							hogdev);

What is the coding style for the userspace? Shall it be at least the same?

Best regards 
Andrei Emeltchenko 



  reply	other threads:[~2012-03-28  8:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 22:31 [RFC 0/8] HoG Plugin João Paulo Rechi Vita
2012-03-27 22:31 ` [RFC 1/8] HoG: Register HID over GATT device driver João Paulo Rechi Vita
2012-03-27 22:31 ` [RFC 2/8] HoG: register ATTIO callbacks João Paulo Rechi Vita
2012-03-28  8:26   ` Andrei Emeltchenko [this message]
2012-03-28 13:55     ` Joao Paulo Rechi Vita
2012-03-28 14:14       ` Andrei Emeltchenko
2012-03-28 18:42         ` Joao Paulo Rechi Vita
2012-03-27 22:31 ` [RFC 3/8] HoG: enable report characteristic notification João Paulo Rechi Vita
2012-03-27 22:31 ` [RFC 4/8] HoG: load primary service handle João Paulo Rechi Vita
2012-03-27 22:31 ` [RFC 5/8] HoG: discover report characteristic João Paulo Rechi Vita
2012-03-27 22:31 ` [RFC 6/8] HoG: add report notification handler João Paulo Rechi Vita
2012-03-27 22:31 ` [RFC 7/8] HoG: print the report map on debug output João Paulo Rechi Vita
2012-03-27 22:31 ` [RFC 8/8] HoG: HID I/O driver João Paulo Rechi Vita
2012-03-28  8:41   ` David Herrmann
2012-03-28 18:40     ` Joao Paulo Rechi Vita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120328082641.GA21905@aemeltch-MOBL1 \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=chen.ganir@ti.com \
    --cc=dh.herrmann@googlemail.com \
    --cc=jprvita@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.