All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 1/3] lib: Correct the HCI Testing OGF value
@ 2012-03-28 14:31 james.steele
  2012-03-28 17:05 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: james.steele @ 2012-03-28 14:31 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: james.steele

This patch corrects the Testing OGF to match the value in the Bluetooth
specification, bringing it in line with the other defined OGF values.
---
 lib/hci.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/hci.h b/lib/hci.h
index 887a860..5fab92d 100644
--- a/lib/hci.h
+++ b/lib/hci.h
@@ -1428,7 +1428,7 @@ typedef struct {
 #define WRITE_REMOTE_AMP_ASSOC_RP_SIZE 2

 /* Testing commands */
-#define OGF_TESTING_CMD                0x3e
+#define OGF_TESTING_CMD                0x06

 #define OCF_READ_LOOPBACK_MODE                 0x0001

--
1.7.0.4




________________________________
Subject to local law, communications with Accenture and its affiliates including telephone calls and emails (including content), may be monitored by our systems for the purposes of security and the assessment of internal compliance with Accenture policy.
______________________________________________________________________________________

www.accenture.com


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3 1/3] lib: Correct the HCI Testing OGF value
  2012-03-28 14:31 [PATCH v3 1/3] lib: Correct the HCI Testing OGF value james.steele
@ 2012-03-28 17:05 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2012-03-28 17:05 UTC (permalink / raw)
  To: james.steele; +Cc: linux-bluetooth

Hi James,

On Wed, Mar 28, 2012, james.steele@accenture.com wrote:
> This patch corrects the Testing OGF to match the value in the Bluetooth
> specification, bringing it in line with the other defined OGF values.
> ---
>  lib/hci.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Where did the git author name info disappear that you had in your
previous submissions? This needs to be part of the patches.

Furthermore, your patches do not actually apply:

error: patch failed: lib/hci.h:1428
error: lib/hci.h: patch does not apply
Patch failed at 0001 lib: Correct the HCI Testing OGF value

On closer inspection it looks like either your mail client or mail
server is converting tabs to spaces. Are you using git send-email?
(which is the preferred way to send patches). Please test sending to
yourself and applying with git am before resending to linux-bluetooth.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-28 17:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-28 14:31 [PATCH v3 1/3] lib: Correct the HCI Testing OGF value james.steele
2012-03-28 17:05 ` Johan Hedberg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.