From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 0 of 2] Support for Paging/Sharing on AMD Date: Thu, 29 Mar 2012 18:41:23 +0200 Message-ID: <20120329164123.GA10693@aepfle.de> References: <20120329110357.GE72859@ocelot.phlegethon.org> <7e6f4eefa902b1d9bbfc918e29c867d7.squirrel@webmail.lagarcavilla.org> <20120329150134.GH72859@ocelot.phlegethon.org> <20120329154243.GI72859@ocelot.phlegethon.org> <20120329160133.GA2616@aepfle.de> <20120329160848.GK72859@ocelot.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120329160848.GK72859@ocelot.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: keir@xen.org, andres@gridcentric.ca, xen-devel@lists.xen.org, wei.wang2@amd.com, Andres Lagar-Cavilla , jbeulich@suse.com, adin@gridcentric.ca List-Id: xen-devel@lists.xenproject.org On Thu, Mar 29, Tim Deegan wrote: > At 18:01 +0200 on 29 Mar (1333044093), Olaf Hering wrote: > > On Thu, Mar 29, Tim Deegan wrote: > > > > > That is, can we just drop this whole test? > > > > I'm ok with removing the existing boot_cpu_data.x86_vendor test, > > check only hap_enabled() and return -ENODEV otherwise. > > > > A recent change added need_iommu() check, this should be moved up into > > the -ENODEV case becasue -EXDEV is for PoD. > > That seems strange -- why would 'no; this VM uses PoD' be different from > 'no; this VM uses the IOMMU'? Its just a made-up return code to have a proper error message in xenpagings init function. > I'll take a patch to change the return code if it also documents it in > the hypercall interface. :) Where is it documented? Olaf