From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata Date: Fri, 30 Mar 2012 11:50:24 +0200 Message-ID: <20120330095024.GS15647@pengutronix.de> References: <20120329211131.GA31250@pengutronix.de> <1333055554-31300-3-git-send-email-u.kleine-koenig@pengutronix.de> <20120330061134.GD3254@S2101-09.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20120330061134.GD3254@S2101-09.ap.freescale.net> Sender: linux-samsung-soc-owner@vger.kernel.org To: Shawn Guo Cc: linux-kernel@vger.kernel.org, Andrew Morton , kernel@pengutronix.de, Andrew Victor , Nicolas Ferre , Jean-Christophe Plagniol-Villard , Russell King , Sekhar Nori , Kevin Hilman , Kukjin Kim , Lennert Buytenhek , Nicolas Pitre , Eric Miao , Haojian Zhuang , David Brown , Daniel Walker , Bryan Huntsman , Tony Lindgren , Barry Song , Andrew Lunn , Lucas De Marchi , linux-arm-kernel@lists.infradead.org, davinci-linux-open-source@linux.davincidsp.com, linux-sa List-Id: linux-arm-msm@vger.kernel.org Hello Shawn, On Fri, Mar 30, 2012 at 02:11:36PM +0800, Shawn Guo wrote: > On Thu, Mar 29, 2012 at 11:12:20PM +0200, Uwe Kleine-K=F6nig wrote: > ... > > diff --git a/arch/arm/mach-imx/imx51-dt.c b/arch/arm/mach-imx/imx51= -dt.c > > index 5cca573..7e00748 100644 > > --- a/arch/arm/mach-imx/imx51-dt.c > > +++ b/arch/arm/mach-imx/imx51-dt.c > > @@ -102,7 +102,7 @@ static struct sys_timer imx51_timer =3D { > > .init =3D imx51_timer_init, > > }; > > =20 > > -static const char *imx51_dt_board_compat[] __initdata =3D { > > +static const char *imx51_dt_board_compat[] __initconst =3D { > > "fsl,imx51-babbage", > > "fsl,imx51", > > NULL >=20 > CC arch/arm/mach-imx/imx51-dt.o > arch/arm/mach-imx/imx51-dt.c:105:20: error: imx51_dt_board_compat cau= ses a section type conflict > make[2]: *** [arch/arm/mach-imx/imx51-dt.o] Error 1 >=20 > I do not understand why though. that's because the strings are constant, but the array is not. The fix is: -static const char *imx51_dt_board_compat[] __initconst =3D { +static const char *const imx51_dt_board_compat[] __initconst =3D { or keeping __initdata. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760594Ab2C3JvK (ORCPT ); Fri, 30 Mar 2012 05:51:10 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:53459 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760577Ab2C3JvD (ORCPT ); Fri, 30 Mar 2012 05:51:03 -0400 Date: Fri, 30 Mar 2012 11:50:24 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Shawn Guo Cc: linux-kernel@vger.kernel.org, Andrew Morton , kernel@pengutronix.de, Andrew Victor , Nicolas Ferre , Jean-Christophe Plagniol-Villard , Russell King , Sekhar Nori , Kevin Hilman , Kukjin Kim , Lennert Buytenhek , Nicolas Pitre , Eric Miao , Haojian Zhuang , David Brown , Daniel Walker , Bryan Huntsman , Tony Lindgren , Barry Song , Andrew Lunn , Lucas De Marchi , linux-arm-kernel@lists.infradead.org, davinci-linux-open-source@linux.davincidsp.com, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata Message-ID: <20120330095024.GS15647@pengutronix.de> References: <20120329211131.GA31250@pengutronix.de> <1333055554-31300-3-git-send-email-u.kleine-koenig@pengutronix.de> <20120330061134.GD3254@S2101-09.ap.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20120330061134.GD3254@S2101-09.ap.freescale.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:21e:67ff:fe11:9c5c X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Shawn, On Fri, Mar 30, 2012 at 02:11:36PM +0800, Shawn Guo wrote: > On Thu, Mar 29, 2012 at 11:12:20PM +0200, Uwe Kleine-König wrote: > ... > > diff --git a/arch/arm/mach-imx/imx51-dt.c b/arch/arm/mach-imx/imx51-dt.c > > index 5cca573..7e00748 100644 > > --- a/arch/arm/mach-imx/imx51-dt.c > > +++ b/arch/arm/mach-imx/imx51-dt.c > > @@ -102,7 +102,7 @@ static struct sys_timer imx51_timer = { > > .init = imx51_timer_init, > > }; > > > > -static const char *imx51_dt_board_compat[] __initdata = { > > +static const char *imx51_dt_board_compat[] __initconst = { > > "fsl,imx51-babbage", > > "fsl,imx51", > > NULL > > CC arch/arm/mach-imx/imx51-dt.o > arch/arm/mach-imx/imx51-dt.c:105:20: error: imx51_dt_board_compat causes a section type conflict > make[2]: *** [arch/arm/mach-imx/imx51-dt.o] Error 1 > > I do not understand why though. that's because the strings are constant, but the array is not. The fix is: -static const char *imx51_dt_board_compat[] __initconst = { +static const char *const imx51_dt_board_compat[] __initconst = { or keeping __initdata. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=) Date: Fri, 30 Mar 2012 11:50:24 +0200 Subject: [PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata In-Reply-To: <20120330061134.GD3254@S2101-09.ap.freescale.net> References: <20120329211131.GA31250@pengutronix.de> <1333055554-31300-3-git-send-email-u.kleine-koenig@pengutronix.de> <20120330061134.GD3254@S2101-09.ap.freescale.net> Message-ID: <20120330095024.GS15647@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Shawn, On Fri, Mar 30, 2012 at 02:11:36PM +0800, Shawn Guo wrote: > On Thu, Mar 29, 2012 at 11:12:20PM +0200, Uwe Kleine-K?nig wrote: > ... > > diff --git a/arch/arm/mach-imx/imx51-dt.c b/arch/arm/mach-imx/imx51-dt.c > > index 5cca573..7e00748 100644 > > --- a/arch/arm/mach-imx/imx51-dt.c > > +++ b/arch/arm/mach-imx/imx51-dt.c > > @@ -102,7 +102,7 @@ static struct sys_timer imx51_timer = { > > .init = imx51_timer_init, > > }; > > > > -static const char *imx51_dt_board_compat[] __initdata = { > > +static const char *imx51_dt_board_compat[] __initconst = { > > "fsl,imx51-babbage", > > "fsl,imx51", > > NULL > > CC arch/arm/mach-imx/imx51-dt.o > arch/arm/mach-imx/imx51-dt.c:105:20: error: imx51_dt_board_compat causes a section type conflict > make[2]: *** [arch/arm/mach-imx/imx51-dt.o] Error 1 > > I do not understand why though. that's because the strings are constant, but the array is not. The fix is: -static const char *imx51_dt_board_compat[] __initconst = { +static const char *const imx51_dt_board_compat[] __initconst = { or keeping __initdata. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |