From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760848Ab2C3P0V (ORCPT ); Fri, 30 Mar 2012 11:26:21 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:48127 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751269Ab2C3P0M (ORCPT ); Fri, 30 Mar 2012 11:26:12 -0400 Date: Fri, 30 Mar 2012 08:26:06 -0700 From: Tejun Heo To: Ren Mingxin Cc: Jens Axboe , "Michael S. Tsirkin" , Rusty Russell , LKML , SCSI , KVM , VIRTUAL Subject: Re: [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming Message-ID: <20120330152606.GB28934@google.com> References: <4F7581D4.4040301@cn.fujitsu.com> <4F7582B0.5010609@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F7582B0.5010609@cn.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 30, 2012 at 05:53:52PM +0800, Ren Mingxin wrote: > The current virtblk's naming algorithm only supports 263 disks. > If there are mass of virtblks(exceeding 263), there will be disks > with the same name. > > By renaming "sd_format_disk_name()" to "disk_name_format()" > and moving it into block core, virtio_blk can use this function to > support mass of disks. > > Signed-off-by: Ren Mingxin I guess it's already way too late but why couldn't they have been named vdD-P where both D and P are integers denoting disk number and partition number? [sh]dX's were created when there weren't supposed to be too many disks, so we had to come up with the horrible alphabet based numbering scheme but vd is new enough. I mean, naming is one thing but who wants to figure out which sequence is or guess what comes next vdzz9? :( If we're gonna move it to block layer, let's add big blinking red comment saying "don't ever use it for any new driver". Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming Date: Fri, 30 Mar 2012 08:26:06 -0700 Message-ID: <20120330152606.GB28934@google.com> References: <4F7581D4.4040301@cn.fujitsu.com> <4F7582B0.5010609@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4F7582B0.5010609@cn.fujitsu.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Ren Mingxin Cc: Jens Axboe , SCSI , KVM , "Michael S. Tsirkin" , LKML , VIRTUAL List-Id: linux-scsi@vger.kernel.org On Fri, Mar 30, 2012 at 05:53:52PM +0800, Ren Mingxin wrote: > The current virtblk's naming algorithm only supports 263 disks. > If there are mass of virtblks(exceeding 263), there will be disks > with the same name. > > By renaming "sd_format_disk_name()" to "disk_name_format()" > and moving it into block core, virtio_blk can use this function to > support mass of disks. > > Signed-off-by: Ren Mingxin I guess it's already way too late but why couldn't they have been named vdD-P where both D and P are integers denoting disk number and partition number? [sh]dX's were created when there weren't supposed to be too many disks, so we had to come up with the horrible alphabet based numbering scheme but vd is new enough. I mean, naming is one thing but who wants to figure out which sequence is or guess what comes next vdzz9? :( If we're gonna move it to block layer, let's add big blinking red comment saying "don't ever use it for any new driver". Thanks. -- tejun