From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751559Ab2DALUb (ORCPT ); Sun, 1 Apr 2012 07:20:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37153 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897Ab2DALU3 (ORCPT ); Sun, 1 Apr 2012 07:20:29 -0400 Date: Sun, 1 Apr 2012 14:20:26 +0300 From: "Michael S. Tsirkin" To: Ren Mingxin Cc: Jens Axboe , Rusty Russell , Tejun Heo , LKML , SCSI , KVM , VIRTUAL Subject: Re: [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format() Message-ID: <20120401112025.GB23773@redhat.com> References: <4F7581D4.4040301@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F7581D4.4040301@cn.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 30, 2012 at 05:50:12PM +0800, Ren Mingxin wrote: > > > This patch series renames "sd_format_disk_name()" to > "disk_name_format()" and moves it into block core. So > that who needs formatting disk name can use it, instead > of duplicating these similar help functions. I see there are some responses about naming and comments, so that would need to be fixed. Besides this, Jens, would you like to take the patchset through your tree or prefer for me to merge it through virtio tree? Block tree seems more appropriate, right? Also this is a bugfix technically since it fixes setups with a ton of disks, so 3.4 material? > Ren Mingxin (4): > block: add function disk_name_format() into block core > scsi: replace sd_format_disk_name() to disk_name_format() > block: replace rssd_disk_name_format() to disk_name_format() > virtio_blk: use disk_name_format() to support mass of disks naming > > block/genhd.c | 49 ++++++++++++++++++++++++++++++++++++++ > drivers/block/mtip32xx/mtip32xx.c | 33 ------------------------- > drivers/block/virtio_blk.c | 13 ---------- > drivers/scsi/sd.c | 48 ------------------------------------- > include/linux/genhd.h | 2 + > 5 files changed, 54 insertions(+), 91 deletions(-) > > Any comment will be appreciated. > > Thanks, > Ren > From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format() Date: Sun, 1 Apr 2012 14:20:26 +0300 Message-ID: <20120401112025.GB23773@redhat.com> References: <4F7581D4.4040301@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4F7581D4.4040301@cn.fujitsu.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Ren Mingxin Cc: Jens Axboe , KVM , SCSI , LKML , VIRTUAL , Tejun Heo List-Id: linux-scsi@vger.kernel.org On Fri, Mar 30, 2012 at 05:50:12PM +0800, Ren Mingxin wrote: > > > This patch series renames "sd_format_disk_name()" to > "disk_name_format()" and moves it into block core. So > that who needs formatting disk name can use it, instead > of duplicating these similar help functions. I see there are some responses about naming and comments, so that would need to be fixed. Besides this, Jens, would you like to take the patchset through your tree or prefer for me to merge it through virtio tree? Block tree seems more appropriate, right? Also this is a bugfix technically since it fixes setups with a ton of disks, so 3.4 material? > Ren Mingxin (4): > block: add function disk_name_format() into block core > scsi: replace sd_format_disk_name() to disk_name_format() > block: replace rssd_disk_name_format() to disk_name_format() > virtio_blk: use disk_name_format() to support mass of disks naming > > block/genhd.c | 49 ++++++++++++++++++++++++++++++++++++++ > drivers/block/mtip32xx/mtip32xx.c | 33 ------------------------- > drivers/block/virtio_blk.c | 13 ---------- > drivers/scsi/sd.c | 48 ------------------------------------- > include/linux/genhd.h | 2 + > 5 files changed, 54 insertions(+), 91 deletions(-) > > Any comment will be appreciated. > > Thanks, > Ren >