[U-Boot] [RFC v0 0/11]: Add <configs/omap3_common.h>

From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC v0 0/11]: Add <configs/omap3_common.h>
Date: Tue, 3 Apr 2012 22:46:27 -0400	[thread overview]
Message-ID: <201204032246.28759.vapier@gentoo.org> (raw)
In-Reply-To: <20120403233505.GA26953@bill-the-cat>

On Tuesday 03 April 2012 19:35:05 Tom Rini wrote:
> On Tue, Apr 03, 2012 at 05:37:37PM -0400, Mike Frysinger wrote:
> > On Thursday 22 March 2012 15:09:06 Tom Rini wrote:
> > > Here's something I've talked about a bit before.  This series adds
> > > include/configs/omap3_common.h and makes all CONFIG_OMAP34XX boards use
> > > it.  This particular round of posting doesn't directly apply as I'm
> > > working off of a series of cleanups that I'll post once I'm sure I
> > > don't find any others from doing this (unused CONFIG options) general
> > > series. What I'm really looking for is feedback on the implementation,
> > > namely what I lay out in the first patch of a section to set before
> > > using omap3_common.h, including, and a section for after
> > > omap3_common.h.  The series isn't nearly complete but introduces at
> > > least one example of a "our board isn't like all the others" in each
> > > of the sections.
> > 
> > seems like for the most part this is soc-specific default configs, and
> > one or two might be a vendor (TI) specific defaults (which aren't really
> > harmful).
> 
> There is a certain amount of this that can be shared with
> omap4/5/am33xx/davinci (since the IP is shared).  I'm not sure of the
> best way to share that yet, but I wanted to do it in steps.

sure.  this is an improvement, so might as well merge it since you've done the 
work.

> > the patches as-is generally look OK, but i wonder if we shouldn't expand
> > the arm asm/config.h to tail into an asm/arch/config.h so these
> > soc-specific defaults can live there rather than include/configs/.
> 
> That's a good idea, I think.  I'll give that a spin and see how it
> looks.

i've got the ADI (vendor) common stuff in include/configs/bfin_adi_common.h, but 
i've put quite a lot of sane stuff into the arch/blackfin/include/asm/config.h 
that makes sense at the arch level.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120403/929a3f47/attachment.pgp>